[MediaWiki-commits] [Gerrit] migrateAccount: Don't bail if the username is falsey ('0') - change (mediawiki...CentralAuth)

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/204296

Change subject: migrateAccount: Don't bail if the username is falsey ('0')
......................................................................

migrateAccount: Don't bail if the username is falsey ('0')

PHP sucks.

Change-Id: I60a6f4b90b1ce698e5b2277876709f70aa472225
---
M maintenance/migrateAccount.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/96/204296/1

diff --git a/maintenance/migrateAccount.php b/maintenance/migrateAccount.php
index 15178fe..a6ddf20 100644
--- a/maintenance/migrateAccount.php
+++ b/maintenance/migrateAccount.php
@@ -67,7 +67,7 @@
                                $this->output( "ERROR - Could not open file: 
$list" );
                                exit( 1 );
                        }
-                       while( $line = trim( fgets( $file ) ) ) {
+                       while( strlen( $line = trim( fgets( $file ) ) ) ) {
                                $values = explode( "\t", $line );
                                switch( count( $values ) ){
                                        case 1:

-- 
To view, visit https://gerrit.wikimedia.org/r/204296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60a6f4b90b1ce698e5b2277876709f70aa472225
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits