Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204476
Change subject: Specific return types in MockClientStore ...................................................................... Specific return types in MockClientStore All these methods are guaranteed to return these types *and* they are already used as such in several places, which causes type warnings in several places. Change-Id: I9b872c4bd088b213c8c2ad02b22eb345a85950cb --- M client/tests/phpunit/MockClientStore.php 1 file changed, 11 insertions(+), 17 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/76/204476/1 diff --git a/client/tests/phpunit/MockClientStore.php b/client/tests/phpunit/MockClientStore.php index a6aaa73..1cef882 100644 --- a/client/tests/phpunit/MockClientStore.php +++ b/client/tests/phpunit/MockClientStore.php @@ -5,16 +5,10 @@ use Wikibase\ChangesTable; use Wikibase\Client\Usage\NullSubscriptionManager; use Wikibase\Client\Usage\NullUsageTracker; -use Wikibase\Client\Usage\SubscriptionManager; -use Wikibase\Client\Usage\UsageLookup; -use Wikibase\Client\Usage\UsageTracker; use Wikibase\ClientStore; -use Wikibase\Lib\Store\EntityLookup; -use Wikibase\Lib\Store\EntityRevisionLookup; use Wikibase\Lib\Store\NullEntityPrefetcher; -use Wikibase\Lib\Store\SiteLinkLookup; use Wikibase\PropertyInfoStore; -use Wikibase\PropertyLabelResolver; +use Wikibase\Store\EntityIdLookup; use Wikibase\TermIndex; /** @@ -52,7 +46,7 @@ /** * @see ClientStore::getUsageLookup * - * @return UsageLookup + * @return NullUsageTracker */ public function getUsageLookup() { return new NullUsageTracker(); @@ -61,7 +55,7 @@ /** * @see ClientStore::getUsageTracker * - * @return UsageTracker + * @return NullUsageTracker */ public function getUsageTracker() { return new NullUsageTracker(); @@ -70,7 +64,7 @@ /** * @see ClientStore::getSubscriptionManager * - * @return SubscriptionManager + * @return NullSubscriptionManager */ public function getSubscriptionManager() { return new NullSubscriptionManager(); @@ -79,7 +73,7 @@ /** * @see ClientStore::getPropertyLabelResolver * - * @return PropertyLabelResolver + * @return MockPropertyLabelResolver */ public function getPropertyLabelResolver() { return new MockPropertyLabelResolver( @@ -100,7 +94,7 @@ /** * @see ClientStore::getEntityIdLookup * - * @return \Wikibase\Store\EntityIdLookup + * @return EntityIdLookup */ public function getEntityIdLookup() { // FIXME: Incomplete @@ -141,7 +135,7 @@ /** * @see ClientStore::getEntityLookup * - * @return EntityLookup + * @return MockRepository */ public function getEntityLookup() { return $this->getMockRepository(); @@ -150,7 +144,7 @@ /** * @see ClientStore::getEntityRevisionLookup * - * @return EntityRevisionLookup + * @return MockRepository */ public function getEntityRevisionLookup() { return $this->getMockRepository(); @@ -159,7 +153,7 @@ /** * @see ClientStore::getSiteLinkLookup * - * @return SiteLinkLookup + * @return MockRepository */ public function getSiteLinkLookup() { return $this->getMockRepository(); @@ -168,7 +162,7 @@ /** * @see ClientStore::getPropertyInfoStore * - * @return PropertyInfoStore + * @return MockPropertyInfoStore */ public function getPropertyInfoStore() { if ( self::$propertyInfoStore === null ) { @@ -181,7 +175,7 @@ /** * @see ClientStore::getEntityPrefetcher * - * @return EntityPrefetcher + * @return NullEntityPrefetcher */ public function getEntityPrefetcher() { return new NullEntityPrefetcher(); -- To view, visit https://gerrit.wikimedia.org/r/204476 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b872c4bd088b213c8c2ad02b22eb345a85950cb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits