jenkins-bot has submitted this change and it was merged.
Change subject: More fixes for updating properties correctly
......................................................................
More fixes for updating properties correctly
Change-Id: Iabfc6c5083d8d721973542ffd7abd1d996a762aa
---
M tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
M
tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Manybubbles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
index 2b20f3b..32f5b29 100644
--- a/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
+++ b/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
@@ -18,7 +18,11 @@
private final Date timestamp;
public Change(String entityId, long revision, Date timestamp) {
- this.entityId = entityId;
+ if(entityId.startsWith("Property:")) {
+ this.entityId = entityId.substring("Property:".length());
+ } else {
+ this.entityId = entityId;
+ }
this.revision = revision;
this.timestamp = timestamp;
}
diff --git
a/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
index f0fe884..e7d27c7 100644
---
a/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
+++
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
@@ -85,8 +85,9 @@
DateFormat df = inputDateFormat();
for (Object rco : result) {
JSONObject rc = (JSONObject) rco;
- if ((long) rc.get("ns") != 0) {
- log.debug("Skipping change in non-0 namespace: {}", rc);
+ // FIXME: this check should probably be gone
+ if ((long) rc.get("ns") != 0 && (long) rc.get("ns") != 120) {
+ log.debug("Skipping change in irrelevant namespace: {}",
rc);
continue;
}
Date timestamp = df.parse(rc.get("timestamp").toString());
--
To view, visit https://gerrit.wikimedia.org/r/204220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabfc6c5083d8d721973542ffd7abd1d996a762aa
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: Jdouglas <jdoug...@wikimedia.org>
Gerrit-Reviewer: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
