Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204699
Change subject: dynamicproxy: Don't open up proxy only to internal users
......................................................................
dynamicproxy: Don't open up proxy only to internal users
Open it to everyone! Rely on security groups to restrict it.
This is being read up from wikitech.
Change-Id: Ib2aedccae922ccf42c32262ff7c7c6510d888730
---
M modules/dynamicproxy/manifests/api.pp
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/99/204699/1
diff --git a/modules/dynamicproxy/manifests/api.pp
b/modules/dynamicproxy/manifests/api.pp
index 8ee8f64..927a882 100644
--- a/modules/dynamicproxy/manifests/api.pp
+++ b/modules/dynamicproxy/manifests/api.pp
@@ -6,7 +6,6 @@
}
ferm::service { 'dynamicproxy-api-http':
- srange => '$INTERNAL', # Use security groups for actual access control
port => $port,
proto => 'tcp',
desc => 'API for adding / removing proxies from dynamicproxy
domainproxy'
--
To view, visit https://gerrit.wikimedia.org/r/204699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2aedccae922ccf42c32262ff7c7c6510d888730
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
