Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204963
Change subject: ve.ui.SpecialCharacterDialog: Update for changes in OOjs ui
......................................................................
ve.ui.SpecialCharacterDialog: Update for changes in OOjs ui
Depends on I9ff531912505f897b75f39a6a8e2ffe435f6f829.
Change-Id: If8cd89dd0035fb570f69c56855c048612971ee91
---
M src/ui/dialogs/ve.ui.SpecialCharacterDialog.js
M src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/63/204963/1
diff --git a/src/ui/dialogs/ve.ui.SpecialCharacterDialog.js
b/src/ui/dialogs/ve.ui.SpecialCharacterDialog.js
index 3f84c79..46e993e 100644
--- a/src/ui/dialogs/ve.ui.SpecialCharacterDialog.js
+++ b/src/ui/dialogs/ve.ui.SpecialCharacterDialog.js
@@ -122,13 +122,10 @@
* Builds the button DOM list based on the character list
*/
ve.ui.SpecialCharacterDialog.prototype.buildButtonList = function () {
- var category,
- // HACK: When displaying this inside a dialog, menu would tend
to be wider than content
- isInsideDialog = !!this.manager.$element.closest(
'.oo-ui-dialog' ).length;
+ var category;
this.bookletLayout = new OO.ui.BookletLayout( {
outlined: true,
- menuSize: isInsideDialog ? '10em' : '18em',
continuous: true
} );
this.pages = [];
diff --git a/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
b/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
index 8404a57..2fbf9bb 100644
--- a/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
+++ b/src/ui/styles/dialogs/ve.ui.SpecialCharacterDialog.css
@@ -22,6 +22,15 @@
height: 150px;
}
+/* When displaying inside another dialog, make the menu narrower */
+.oo-ui-dialog .ve-ui-specialCharacterDialog .oo-ui-bookletLayout
.oo-ui-menuLayout-menu {
+ width: 10em;
+}
+
+.oo-ui-dialog .ve-ui-specialCharacterDialog .oo-ui-bookletLayout
.oo-ui-menuLayout-content {
+ left: 10em;
+}
+
.oo-ui-bookletLayout-stackLayout > .ve-ui-specialCharacterPage {
padding: 0.5em;
}
--
To view, visit https://gerrit.wikimedia.org/r/204963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8cd89dd0035fb570f69c56855c048612971ee91
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
