Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/205297
Change subject: Add isset checks for array in CollectionsList ...................................................................... Add isset checks for array in CollectionsList Change-Id: I86cbd9a0456d67990682ad2f65c0aba2fb5bf822 --- M includes/models/CollectionsList.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather refs/changes/97/205297/1 diff --git a/includes/models/CollectionsList.php b/includes/models/CollectionsList.php index 386213d..9095cd8 100644 --- a/includes/models/CollectionsList.php +++ b/includes/models/CollectionsList.php @@ -149,8 +149,8 @@ if ( isset( $data['query']['lists'] ) ) { $lists = $data['query']['lists']; foreach ( $lists as $list ) { - if ( $list['public'] || $includePrivate ) { - $image = $list['image'] ? wfFindFile( $list['image'] ) : false; + if ( isset( $list['public'] ) && ( $list['public'] || $includePrivate ) ) { + $image = isset( $list['image'] ) ? wfFindFile( $list['image'] ) : false; $info = new models\CollectionInfo( $list['id'], $user, $list['label'], $list['description'], $list['public'], $image ); $info->setCount( $list['count'] ); -- To view, visit https://gerrit.wikimedia.org/r/205297 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I86cbd9a0456d67990682ad2f65c0aba2fb5bf822 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits