Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205475
Change subject: Correct display for full-screen dialogs in Mobile VE
......................................................................
Correct display for full-screen dialogs in Mobile VE
Dialogs should not be position:fixed in mobile as they are full
screen, and that behavior is dangerously buggy in mobile webkit.
Also remove the rules that hide template pieces in mobile so we
can show the citation dialogs in all their glory and function.
* Depends on ve-core fix I748123a362f9
Bug: T86233
Change-Id: I3daa2b733a7685cb5ff127625f6d2e51b416ec33
---
M VisualEditor.php
M extension.json
M modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWParameterPage.css
D modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWTemplatePage.css
A modules/ve-mw/ui/themes/minerva/ve.ui.MobileWindowManager.css
5 files changed, 17 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/75/205475/1
diff --git a/VisualEditor.php b/VisualEditor.php
index a87745c..6d7edea 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -1416,7 +1416,7 @@
),
'minerva' => array(
'modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWParameterPage.css',
-
'modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWTemplatePage.css',
+
'modules/ve-mw/ui/themes/minerva/ve.ui.MobileWindowManager.css',
),
),
'dependencies' => array(
diff --git a/extension.json b/extension.json
index 9e480ee..0854e93 100644
--- a/extension.json
+++ b/extension.json
@@ -1432,7 +1432,7 @@
],
"minerva": [
"modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWParameterPage.css",
-
"modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWTemplatePage.css"
+
"modules/ve-mw/ui/themes/minerva/ve.ui.MobileWindowManager.css"
]
},
"dependencies": [
diff --git a/modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWParameterPage.css
b/modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWParameterPage.css
index 9f847db..67e5081 100644
--- a/modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWParameterPage.css
+++ b/modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWParameterPage.css
@@ -44,4 +44,9 @@
.ve-ui-mwParameterPage-more {
display: none;
+ margin: 1em 0 0.5em 0;
+}
+
+.ve-ui-mwParameterPage:last-child .ve-ui-mwParameterPage-more {
+ display: block;
}
diff --git a/modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWTemplatePage.css
b/modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWTemplatePage.css
deleted file mode 100644
index 0c1f62f..0000000
--- a/modules/ve-mw/ui/themes/minerva/pages/ve.ui.MWTemplatePage.css
+++ /dev/null
@@ -1,14 +0,0 @@
-/*!
- * VisualEditor MediaWiki UserInterface TemplatePage styles.
- *
- * @copyright 2011-2015 VisualEditor Team and others; see AUTHORS.txt
- * @license The MIT License (MIT); see LICENSE.txt
- */
-
-.ve-ui-mwTemplatePage-more {
- display: none;
-}
-
-.ve-ui-mwTemplatePage-description {
- display: none;
-}
diff --git a/modules/ve-mw/ui/themes/minerva/ve.ui.MobileWindowManager.css
b/modules/ve-mw/ui/themes/minerva/ve.ui.MobileWindowManager.css
new file mode 100644
index 0000000..33488a2
--- /dev/null
+++ b/modules/ve-mw/ui/themes/minerva/ve.ui.MobileWindowManager.css
@@ -0,0 +1,10 @@
+/*!
+ * VisualEditor MediaWiki UserInterface MobileWindowManager styles.
+ *
+ * @copyright 2011-2015 VisualEditor Team and others; see AUTHORS.txt
+ * @license The MIT License (MIT); see LICENSE.txt
+ */
+
+.ve-ui-mobileWindowManager > .oo-ui-dialog {
+ position: absolute;
+}
--
To view, visit https://gerrit.wikimedia.org/r/205475
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3daa2b733a7685cb5ff127625f6d2e51b416ec33
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
