Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205572
Change subject: Adjust BotEditTest for core api change
......................................................................
Adjust BotEditTest for core api change
not actually sure yet this is the right thing to
do, but this is where the problem is.
Change-Id: If0c0fe2ee70ca22da9365fd9417bac7221201c21
---
M repo/tests/phpunit/includes/api/BotEditTest.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/72/205572/1
diff --git a/repo/tests/phpunit/includes/api/BotEditTest.php
b/repo/tests/phpunit/includes/api/BotEditTest.php
index 7ad0607..78fa494 100644
--- a/repo/tests/phpunit/includes/api/BotEditTest.php
+++ b/repo/tests/phpunit/includes/api/BotEditTest.php
@@ -151,9 +151,11 @@
$this->assertTrue( $expected['new'] ==
array_key_exists( 'new', $change ),
"Must " . ( $expected['new'] ? '' : 'not ' ) .
"have a 'new' key in the rc-entry of the result from the API" );
}
+
if ( array_key_exists( 'bot', $expected ) ){
- $this->assertTrue( $expected['bot'] ==
array_key_exists( 'bot', $change ),
- "Must " . ( $expected['bot'] ? '' : 'not ' ) .
"have a 'bot' key in the rc-entry of the result from the API" );
+ $this->assertTrue( $expected['bot'] === $change['bot'],
"Value of 'bot' key in the "
+ . 'in the rc-entry of the result was expected
to be ' . $expected['bot']
+ . ' but was ' . $change['bot'] );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/205572
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If0c0fe2ee70ca22da9365fd9417bac7221201c21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
