Filippo Giunchedi has submitted this change and it was merged.
Change subject: wmf-reimage: handle unset IPMI_PASSWORD
......................................................................
wmf-reimage: handle unset IPMI_PASSWORD
Change-Id: Ia2a891240dc2ffd3016811e23cada0bd7192bb00
---
M modules/puppetmaster/files/wmf-reimage
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Filippo Giunchedi: Verified; Looks good to me, approved
diff --git a/modules/puppetmaster/files/wmf-reimage
b/modules/puppetmaster/files/wmf-reimage
index 7305fab..a26b4b3 100755
--- a/modules/puppetmaster/files/wmf-reimage
+++ b/modules/puppetmaster/files/wmf-reimage
@@ -101,7 +101,7 @@
function set_pxe_and_reboot {
mgmtname=${1}
- if [ -z "$IPMI_PASSWORD" ]; then
+ if [ -z "${IPMI_PASSWORD:-}" ]; then
echo "WARNING: IPMI_PASSWORD not found."
if ! tty -s; then
echo "Assuming bash, do: "
--
To view, visit https://gerrit.wikimedia.org/r/205835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2a891240dc2ffd3016811e23cada0bd7192bb00
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
