Deskana has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206071
Change subject: Hygiene: miscellaneous code quality fixes
......................................................................
Hygiene: miscellaneous code quality fixes
* Removed unused variable from SuggestedPagesFunnel
* Removed overriden methods that do nothing except call their parent method
* Changed an assign/if/return code block into a return statement in ShareUtils
Change-Id: Ib95087718e78de6ae819ff445e1325d71c1f0829
---
M wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
M
wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryFragment.java
M wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
M wikipedia/src/main/java/org/wikipedia/util/ShareUtils.java
4 files changed, 1 insertion(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/71/206071/1
diff --git
a/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
b/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
index b39f51c..596569a 100644
--- a/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
+++ b/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
@@ -15,7 +15,6 @@
private static final int REV_ID = 11448426;
private final String appInstallID;
- private final Site site;
private final int version;
public SuggestedPagesFunnel(WikipediaApp app, Site site, int version) {
@@ -24,7 +23,6 @@
//Retrieve this app installation's unique ID, used to record unique
users of features
appInstallID = app.getAppInstallID();
- this.site = site;
this.version = version;
}
diff --git
a/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryFragment.java
b/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryFragment.java
index f56dd6e..b5ff1f6 100644
---
a/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryFragment.java
+++
b/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryFragment.java
@@ -63,11 +63,6 @@
summaryText, title);
}
- @Override
- public void onDestroyView() {
- super.onDestroyView();
- }
-
/**
* Shows (fades in) the custom edit summary fragment.
* When fade-in completes, the keyboard is shown automatically, and the
state
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
b/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
index 8bc7ead..e5f7b60 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/gallery/GalleryActivity.java
@@ -236,11 +236,6 @@
}
@Override
- protected void onPause() {
- super.onPause();
- }
-
- @Override
protected void onDestroy() {
super.onDestroy();
Crouton.cancelAllCroutons();
diff --git a/wikipedia/src/main/java/org/wikipedia/util/ShareUtils.java
b/wikipedia/src/main/java/org/wikipedia/util/ShareUtils.java
index f381dec..aca52b6 100644
--- a/wikipedia/src/main/java/org/wikipedia/util/ShareUtils.java
+++ b/wikipedia/src/main/java/org/wikipedia/util/ShareUtils.java
@@ -126,11 +126,7 @@
}
private static boolean isExternalStorageWritable() {
- String state = Environment.getExternalStorageState();
- if (Environment.MEDIA_MOUNTED.equals(state)) {
- return true;
- }
- return false;
+ return
Environment.MEDIA_MOUNTED.equals(Environment.getExternalStorageState());
}
private static String cleanFileName(String fileName) {
--
To view, visit https://gerrit.wikimedia.org/r/206071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib95087718e78de6ae819ff445e1325d71c1f0829
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <dga...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
