Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: show Sprint start and end fields on Project create form by 
default
......................................................................


show Sprint start and end fields on Project create form by default

Bug: T89859
Change-Id: Ie4627258f36213ce181328496c0b671879c97c19
---
M README.md
M src/customfield/SprintProjectCustomField.php
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved

Objections:
  jenkins-bot: Fails



diff --git a/README.md b/README.md
index 7c2ef34..203f154 100644
--- a/README.md
+++ b/README.md
@@ -31,7 +31,7 @@
 2. run git clone 
https://github.com/wikimedia/phabricator-extensions-Sprint.git 
/srv/phab/libext/Sprint
 3. from the /srv/phab/phabricator/bin directory
 - run ./config set load-libraries '{"sprint":"/srv/phab/libext/Sprint/src"}'
-4. create a symlink to link static files from the Sprint extension in the 
phabricator /webroot/rsrc directory: 
+4. create a symlink to link static files from the Sprint extension in the 
phabricator /webroot/rsrc directory:
 - ln -s /srv/phab/libext/Sprint/rsrc/webroot-static 
/srv/phab/phabricator/webroot/rsrc/libext
 
 **BUGS**
diff --git a/src/customfield/SprintProjectCustomField.php 
b/src/customfield/SprintProjectCustomField.php
index d230c52..5bed886 100644
--- a/src/customfield/SprintProjectCustomField.php
+++ b/src/customfield/SprintProjectCustomField.php
@@ -75,13 +75,13 @@
    * @param string $time
    */
   public function renderDateProxyEditControl($dateproxy, $time) {
-    $issprint = $this->isSprint();
+//    $issprint = $this->isSprint();
 
-    if ($issprint && $dateproxy) {
+//    if ($issprint && $dateproxy) {
         return $this->newDateControl($dateproxy, $time);
-    } else {
-      return null;
-    }
+//    } else {
+//      return null;
+//    }
    }
 
   public function renderPropertyViewLabel() {

-- 
To view, visit https://gerrit.wikimedia.org/r/205591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4627258f36213ce181328496c0b671879c97c19
Gerrit-PatchSet: 3
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>
Gerrit-Reviewer: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to