Cscott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/206135

Change subject: Remove redundant \r handling.
......................................................................

Remove redundant \r handling.

The HTML parsing spec already handles \r; \r characters will never show up
in the parsed DOM.  See:
http://www.w3.org/TR/html5/syntax.html#preprocessing-the-input-stream

(Simply removing \r as the old code did is slightly incorrect: Mac OS
9 and earlier used single \r characters to separate lines.  These
should be turned into \n, not removed.)

Change-Id: I8a90950fbbf7b81b5c0cae5b32e51e4726dccf55
---
M api/routes.js
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/35/206135/1

diff --git a/api/routes.js b/api/routes.js
index a5d0ce5..144d86a 100644
--- a/api/routes.js
+++ b/api/routes.js
@@ -239,8 +239,6 @@
                        env.conf.parsoid.allowCORS );
        }
 
-       html = html.replace(/\r/g, '');
-
        if (timer) {
                startTimers.set('html2wt.init.domparse', Date.now());
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/206135
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a90950fbbf7b81b5c0cae5b32e51e4726dccf55
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <canan...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to