Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/206154
Change subject: Hygiene: Fix jscs issues in Gather ...................................................................... Hygiene: Fix jscs issues in Gather Change-Id: I38074bcc1d8499c57708492e71393f78bd4163a3 --- M resources/ext.gather.init/init.js M resources/ext.gather.special/init.js M resources/ext.gather.watchstar/CollectionsContentOverlay.js 3 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather refs/changes/54/206154/1 diff --git a/resources/ext.gather.init/init.js b/resources/ext.gather.init/init.js index 949a9de..71cd1ec 100644 --- a/resources/ext.gather.init/init.js +++ b/resources/ext.gather.init/init.js @@ -108,7 +108,9 @@ } ); p.show(); // FIXME: Hacky.. Should use MainMenu but Bug: T93257. - tag = new Tag( { label: 'new' } ).appendTo( '#mw-mf-page-left .collection-menu-item' ); + tag = new Tag( { + label: 'new' + } ).appendTo( '#mw-mf-page-left .collection-menu-item' ); } } ); } diff --git a/resources/ext.gather.special/init.js b/resources/ext.gather.special/init.js index a638103..b4a2137 100644 --- a/resources/ext.gather.special/init.js +++ b/resources/ext.gather.special/init.js @@ -33,7 +33,9 @@ ev.stopPropagation(); ev.preventDefault(); if ( !$flag.hasClass( 'disabled' ) ) { - flagOverlay = new CollectionFlagOverlay( { collection: collection } ); + flagOverlay = new CollectionFlagOverlay( { + collection: collection + } ); flagOverlay.show(); flagOverlay.on( 'collection-flagged', function () { // After flagging, prevent click from opening flag confirmation again diff --git a/resources/ext.gather.watchstar/CollectionsContentOverlay.js b/resources/ext.gather.watchstar/CollectionsContentOverlay.js index bafe8cf..541a14f 100644 --- a/resources/ext.gather.watchstar/CollectionsContentOverlay.js +++ b/resources/ext.gather.watchstar/CollectionsContentOverlay.js @@ -105,6 +105,9 @@ CollectionsContentOverlayBase.prototype.postRender.apply( this, arguments ); this.expandForm(); }, + /** + * Adjust the form so that it takes up the available screen. + */ expandForm: function () { // FIXME: This selectors might change in future. Yuck. var $btn = this.$( 'form .oo-ui-widget' ); -- To view, visit https://gerrit.wikimedia.org/r/206154 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I38074bcc1d8499c57708492e71393f78bd4163a3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits