Andreasburmeister has submitted this change and it was merged.

Change subject: Remove global scope assumptions in entry point
......................................................................


Remove global scope assumptions in entry point

See 
http://www.bn2vs.com/blog/2013/11/24/introduction-to-composer-for-mediawiki-developers/

Change-Id: I7dc639f7454a1a1e61389d4643c4268dadaa77f0
---
M WikidataQualityConstraints.php
1 file changed, 25 insertions(+), 24 deletions(-)

Approvals:
  Andreasburmeister: Verified; Looks good to me, approved



diff --git a/WikidataQualityConstraints.php b/WikidataQualityConstraints.php
index c567a36..cdd4029 100644
--- a/WikidataQualityConstraints.php
+++ b/WikidataQualityConstraints.php
@@ -13,34 +13,35 @@
        require_once __DIR__ . '/vendor/autoload.php';
 }
 
-// Set credits
-$wgExtensionCredits[ 'specialpage' ][ ] = array (
-       'path' => __FILE__,
-       'name' => 'WikidataQualityConstraints',
-       'author' => 'BP2014N1',
-       'url' => 
'https://www.mediawiki.org/wiki/Extension:WikidataQualityConstraints',
-       'descriptionmsg' => 'wikidataquality-constraints-desc',
-       'version' => '0.0.0'
-);
+call_user_func( function() {
+       // Set credits
+       $GLOBALS['wgExtensionCredits']['specialpage'][] = array(
+               'path' => __FILE__,
+               'name' => 'WikidataQualityConstraints',
+               'author' => 'BP2014N1',
+               'url' => 
'https://www.mediawiki.org/wiki/Extension:WikidataQualityConstraints',
+               'descriptionmsg' => 'wikidataquality-constraints-desc',
+               'version' => '0.0.0'
+       );
 
-// Initialize localization and aliases
-$wgMessagesDirs[ 'WikidataQualityConstraints' ] = __DIR__ . '/i18n';
-$wgExtensionMessagesFiles[ 'WikidataQualityConstraintsAlias' ] = __DIR__ . 
'/WikidataQualityConstraints.alias.php';
+       // Initialize localization and aliases
+       $GLOBALS['wgMessagesDirs']['WikidataQualityConstraints'] = __DIR__ . 
'/i18n';
+       $GLOBALS['wgExtensionMessagesFiles']['WikidataQualityConstraintsAlias'] 
= __DIR__ . '/WikidataQualityConstraints.alias.php';
 
-// Initalize hooks for creating database tables
-global $wgHooks;
-$wgHooks[ 'LoadExtensionSchemaUpdates' ][ ] = 
'WikidataQualityConstraintsHooks::onCreateSchema';
+       // Initalize hooks for creating database tables
+       $GLOBALS['wgHooks']['LoadExtensionSchemaUpdates'][] = 
'WikidataQualityConstraintsHooks::onCreateSchema';
 
-// Register hooks for Unit Tests
-$wgHooks[ 'UnitTestsList' ][ ] = 
'WikidataQualityConstraintsHooks::onUnitTestsList';
+       // Register hooks for Unit Tests
+       $GLOBALS['wgHooks']['UnitTestsList'][] = 
'WikidataQualityConstraintsHooks::onUnitTestsList';
 
-$wgHooks[ 'NewRevisionFromEditComplete' ][] = 
'WikidataQualityConstraintsHooks::onNewRevisionFromEditComplete';
+       $GLOBALS['wgHooks']['NewRevisionFromEditComplete'][] = 
'WikidataQualityConstraintsHooks::onNewRevisionFromEditComplete';
 
-// Initialize special pages
-$wgSpecialPages[ 'ConstraintReport' ] = 
'WikidataQuality\ConstraintReport\Specials\SpecialConstraintReport';
+       // Initialize special pages
+       $GLOBALS['wgSpecialPages']['ConstraintReport'] = 
'WikidataQuality\ConstraintReport\Specials\SpecialConstraintReport';
 
-// Define database table names
-define( 'CONSTRAINT_TABLE', 'wdqa_constraints' );
+       // Define database table names
+       define( 'CONSTRAINT_TABLE', 'wdqa_constraints' );
 
-// Jobs
-$wgJobClasses[ 'checkForConstraintViolations' ] = 
'CheckForConstraintViolationsJob';
\ No newline at end of file
+       // Jobs
+       $GLOBALS['wgJobClasses']['checkForConstraintViolations'] = 
'CheckForConstraintViolationsJob';
+} );
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/206220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7dc639f7454a1a1e61389d4643c4268dadaa77f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Andreasburmeister <andreas.burmeis...@student.hpi.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to