Jonaskeutel has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206383
Change subject: stop writing violations into table
......................................................................
stop writing violations into table
since we decided not to have this feature in the first version
Change-Id: Ic4c536da83d7a4401bc4f95fc12e73985d360bee
---
M specials/SpecialCrossCheck.php
1 file changed, 0 insertions(+), 15 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityExternalValidation
refs/changes/83/206383/1
diff --git a/specials/SpecialCrossCheck.php b/specials/SpecialCrossCheck.php
index 4056e83..a1877d5 100755
--- a/specials/SpecialCrossCheck.php
+++ b/specials/SpecialCrossCheck.php
@@ -9,8 +9,6 @@
use Wikibase\DataModel\Entity\EntityId;
use WikidataQuality\ExternalValidation\CrossCheck\CrossChecker;
use WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResult;
-use
WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultToViolationTranslator;
-use WikidataQuality\Violations\ViolationStore;
use WikidataQuality\Html\HtmlTable;
use WikidataQuality\Html\HtmlTableHeader;
use WikidataQuality\Specials\SpecialCheckResultPage;
@@ -64,8 +62,6 @@
protected function executeCheck( EntityDocument $entity ) {
$crossChecker = new CrossChecker();
$results = $crossChecker->crossCheckEntity( $entity );
-
- $this->saveResultsInViolationsTable( $entity, $results );
return $results;
}
@@ -132,15 +128,4 @@
CrossCheckResult::STATUS_DATA_MISMATCH => 'error'
);
}
-
- /**
- * @param EntityDocument $entity
- * @param array $results
- */
- protected function saveResultsInViolationsTable( $entity, $results ) {
- $translator = new CrossCheckResultToViolationTranslator();
- $violations = $translator->translateToViolation( $entity, $results );
- $violationStore = new ViolationStore();
- $violationStore->insertViolations( $violations );
- }
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/206383
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4c536da83d7a4401bc4f95fc12e73985d360bee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: v1
Gerrit-Owner: Jonaskeutel <jonas.keu...@student.hpi.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
