jenkins-bot has submitted this change and it was merged.
Change subject: Avoid pointless master connections in setViewTabs()
......................................................................
Avoid pointless master connections in setViewTabs()
Change-Id: I44e383464680bc5cc611e5d964c485b97ac9908d
---
M frontend/FlaggablePageView.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
old mode 100644
new mode 100755
index 2079e66..962b71f
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -1251,7 +1251,7 @@
return true; // short-circuit for non-reviewable pages
}
# Hack for bug 16734 (some actions update and view all at once)
- if ( $this->pageWriteOpRequested() && wfGetDB( DB_MASTER
)->doneWrites() ) {
+ if ( $this->pageWriteOpRequested() &&
wfGetLB()->hasOrMadeRecentMasterChanges() ) {
# Tabs need to reflect the new stable version so users
actually
# see the results of their action (i.e.
"delete"/"rollback")
$this->article->loadPageData( 'fromdbmaster' );
--
To view, visit https://gerrit.wikimedia.org/r/206409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44e383464680bc5cc611e5d964c485b97ac9908d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
