[MediaWiki-commits] [Gerrit] Fix for page history sections showing only time instead of d... - change (apps...wikipedia)

[Fjalapeno (Code Review)]

Fjalapeno has submitted this change and it was merged.

Change subject: Fix for page history sections showing only time instead of date.
......................................................................


Fix for page history sections showing only time instead of date.

T96268

Change-Id: I6b7cda512ad90dc40b139d85c245196bfcac91f7
---
M Wikipedia/Categories/NSDateFormatter+WMFExtensions.h
M Wikipedia/Categories/NSDateFormatter+WMFExtensions.m
M Wikipedia/View Controllers/PageHistory/PageHistoryViewController.m
3 files changed, 20 insertions(+), 2 deletions(-)

Approvals:
  Fjalapeno: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Wikipedia/Categories/NSDateFormatter+WMFExtensions.h 
b/Wikipedia/Categories/NSDateFormatter+WMFExtensions.h
index 7815191..31117d8 100644
--- a/Wikipedia/Categories/NSDateFormatter+WMFExtensions.h
+++ b/Wikipedia/Categories/NSDateFormatter+WMFExtensions.h
@@ -33,4 +33,9 @@
  */
 + (NSDateFormatter*)wmf_shortTimeFormatterWithLocale:(NSLocale*)locale;
 
+/**
+ * Create a long style date formatter. Sample: "April 24, 2015".
+ */
++ (NSDateFormatter*)wmf_longDateFormatter;
+
 @end
diff --git a/Wikipedia/Categories/NSDateFormatter+WMFExtensions.m 
b/Wikipedia/Categories/NSDateFormatter+WMFExtensions.m
index 43e7da5..51d1ef5 100644
--- a/Wikipedia/Categories/NSDateFormatter+WMFExtensions.m
+++ b/Wikipedia/Categories/NSDateFormatter+WMFExtensions.m
@@ -37,4 +37,18 @@
     return shortTimeFormatter;
 }
 
++ (NSDateFormatter*)wmf_longDateFormatter {
+    static NSDateFormatter* longDateFormatter = nil;
+    if (!longDateFormatter) {
+        // See: https://www.mediawiki.org/wiki/Manual:WfTimestamp
+        longDateFormatter = [[NSDateFormatter alloc] init];
+        [longDateFormatter setTimeZone:[NSTimeZone timeZoneWithName:@"UTC"]];
+        [longDateFormatter setDateFormat:@"yyyy'-'MM'-'dd'T'HH':'mm':'ss'Z'"];
+        longDateFormatter.dateStyle         = NSDateFormatterLongStyle;
+        longDateFormatter.timeStyle         = NSDateFormatterNoStyle;
+        longDateFormatter.formatterBehavior = NSDateFormatterBehavior10_4;
+    }
+    return longDateFormatter;
+}
+
 @end
diff --git a/Wikipedia/View Controllers/PageHistory/PageHistoryViewController.m 
b/Wikipedia/View Controllers/PageHistory/PageHistoryViewController.m
index d2b0960..abc191b 100644
--- a/Wikipedia/View Controllers/PageHistory/PageHistoryViewController.m
+++ b/Wikipedia/View Controllers/PageHistory/PageHistoryViewController.m
@@ -193,8 +193,7 @@
 
     NSNumber* daysAgo = sectionDict[@"daysAgo"];
     NSDate* date      = [NSDate dateWithDaysBeforeNow:daysAgo.integerValue];
-
-    label.text = [[NSDateFormatter wmf_shortTimeFormatter] 
stringFromDate:date];
+    label.text = [[NSDateFormatter wmf_longDateFormatter] stringFromDate:date];
 
     [view addSubview:label];
 

-- 
To view, visit https://gerrit.wikimedia.org/r/206439
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b7cda512ad90dc40b139d85c245196bfcac91f7
Gerrit-PatchSet: 2
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Bgerstle <bgers...@wikimedia.org>
Gerrit-Reviewer: Dr0ptp4kt <ab...@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits