Tamslo has submitted this change and it was merged. Change subject: remove violationTranslator; don't save violations anymore ......................................................................
remove violationTranslator; don't save violations anymore since we decided not to have this in version 1 Change-Id: I50194977a36fba679464ee3c87d920e62c00b296 --- D includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php M specials/SpecialCrossCheck.php D tests/phpunit/CrossCheck/Result/CrossCheckResultToViolationTranslatorTest.php 3 files changed, 0 insertions(+), 184 deletions(-) Approvals: Tamslo: Verified; Looks good to me, approved diff --git a/includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php b/includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php deleted file mode 100755 index 453bb12..0000000 --- a/includes/CrossCheck/Result/CrossCheckResultToViolationTranslator.php +++ /dev/null @@ -1,49 +0,0 @@ -<?php - -namespace WikidataQuality\ExternalValidation\CrossCheck\Result; - -use Wikibase\DataModel\Entity\ItemId; -use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\DataModel\Entity\Entity; -use WikidataQuality\Result\ResultToViolationTranslator; -use WikidataQuality\Violations\Violation; -use Doctrine\Instantiator\Exception\InvalidArgumentException; - - -class CrossCheckResultToViolationTranslator extends ResultToViolationTranslator { - - public function translateToViolation( Entity $entity, CrossCheckResultList $crossCheckResultList ) { - - $violationArray = array(); - foreach( $crossCheckResultList as $crossCheckResult ) { - if( $crossCheckResult->getStatus() !== CrossCheckResult::STATUS_DATA_MISMATCH ){ - continue; - } - - $entityId = $entity->getId(); - $statement = array( - 'pid' => $crossCheckResult->getPropertyId(), - 'claimGuid' => $crossCheckResult->getClaimGuid() - ); - - //TODO: Use real ClaimGuid and TypeEntityId - $constraintTypeEntityId = $crossCheckResult->getDumpMetaInformation()->getSourceItemId(); - $constraintClaimGuid = $crossCheckResult->getDumpMetaInformation()->getImportDate()->format( 'YmdHis' ) . $constraintTypeEntityId; - - $constraintClaimGuid = md5( $constraintClaimGuid ); - $revisionId = $this->getRevisionIdForEntity( $entityId ); - $status = CrossCheckResult::STATUS_DATA_MISMATCH; - $additionalInformation = array( - 'dump_id' => $crossCheckResult->getDumpMetaInformation()->getDumpId(), - 'external_values' => $crossCheckResult->getCompareResult()->getExternalValues() - - ); - $additionalInformation = json_encode( $additionalInformation ); - - $violationArray[] = new Violation( $entityId, $statement, $constraintClaimGuid, $constraintTypeEntityId, $revisionId, $status, $additionalInformation); - } - - return $violationArray; - } - -} \ No newline at end of file diff --git a/specials/SpecialCrossCheck.php b/specials/SpecialCrossCheck.php index 6a6c369..a41bede 100755 --- a/specials/SpecialCrossCheck.php +++ b/specials/SpecialCrossCheck.php @@ -9,10 +9,8 @@ use Wikibase\DataModel\Entity\EntityId; use WikidataQuality\ExternalValidation\CrossCheck\CrossChecker; use WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResult; -use WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultToViolationTranslator; use WikidataQuality\ExternalValidation\CheckForCrossCheckViolationsJob; use JobQueueGroup; -use WikidataQuality\Violations\ViolationStore; use WikidataQuality\Html\HtmlTable; use WikidataQuality\Html\HtmlTableHeader; use WikidataQuality\Specials\SpecialCheckResultPage; @@ -68,8 +66,6 @@ $results = $crossChecker->crossCheckEntity(); $this->doEvaluation( $entity, $results ); - - $this->saveResultsInViolationsTable( $entity, $results ); return $results; } @@ -135,17 +131,6 @@ CrossCheckResult::STATUS_REFERENCES_MISSING => 'warning', CrossCheckResult::STATUS_DATA_MISMATCH => 'error' ); - } - - /** - * @param EntityDocument $entity - * @param array $results - */ - protected function saveResultsInViolationsTable( $entity, $results ) { - $translator = new CrossCheckResultToViolationTranslator(); - $violations = $translator->translateToViolation( $entity, $results ); - $violationStore = new ViolationStore(); - $violationStore->insertViolations( $violations ); } protected function doEvaluation( $entity, $results ) { diff --git a/tests/phpunit/CrossCheck/Result/CrossCheckResultToViolationTranslatorTest.php b/tests/phpunit/CrossCheck/Result/CrossCheckResultToViolationTranslatorTest.php deleted file mode 100755 index 43d15d9..0000000 --- a/tests/phpunit/CrossCheck/Result/CrossCheckResultToViolationTranslatorTest.php +++ /dev/null @@ -1,120 +0,0 @@ -<?php - -namespace WikidataQuality\ExternalValidation\Test\CrossCheck\Result; - -use Wikibase\DataModel\Entity\Item; -use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\DataModel\Entity\ItemId; -use DateTime; -use WikidataQuality\ExternalValidation\CrossCheck\Result\CompareResult; -use WikidataQuality\ExternalValidation\CrossCheck\Result\ReferenceResult; -use WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResult; -use WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultList; -use WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultToViolationTranslator; -use WikidataQuality\ExternalValidation\DumpMetaInformation; -use Wikibase\Repo\WikibaseRepo; - - -/** - * @covers WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultToViolationTranslator - * - * @group Database - * @group medium - * - * @uses WikidataQuality\ExternalValidation\DumpMetaInformation - * @uses WikidataQuality\ExternalValidation\CrossCheck\Result\CompareResult - * @uses WikidataQuality\ExternalValidation\CrossCheck\Result\ReferenceResult - * @uses WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResult - * @uses WikidataQuality\ExternalValidation\CrossCheck\Result\CrossCheckResultList - * - * @author BP2014N1 - * @license GNU GPL v2+ - */ -class CrossCheckResultToViolationTranslatorTest extends \MediaWikiTestCase { - - private $translator; - private $propertyId; - private $claimGuid; - private $entity; - private $dumpMetaInformation; - private $referenceResult; - - /** - * @var EntityId[] - */ - private static $idMap; - - protected function setUp() { - parent::setUp(); - $this->translator = new CrossCheckResultToViolationTranslator(); - - $this->propertyId = new PropertyId( 'P1' ); - $this->entity = new Item(); - $store = WikibaseRepo::getDefaultInstance()->getEntityStore(); - $store->saveEntity( $this->entity, 'TestEntityQ1', $GLOBALS[ 'wgUser' ], EDIT_NEW ); - self::$idMap[ 'Q1' ] = $this->entity->getId(); - $this->claimGuid = self::$idMap[ 'Q1' ] . '$aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee'; - - $this->dumpMetaInformation = new DumpMetaInformation( - 'foo', - new ItemId( 'Q123456' ), - new DateTime( '2015-01-01 00:00:00' ), - 'en', - 'http://www.foo.bar', - 42, - new ItemId( 'Q6938433' ) - ); - - $this->referenceResult = new ReferenceResult( - false, - $this->getReferenceMock() - ); - - } - - protected function tearDown() { - parent::tearDown(); - unset( $this->translator, $this->propertyId, $this->claimGuid, $this->entity, $this->dumpMetaInformation, $this->referenceResult ); - } - - public function testSingleComplianceResult() { - $compareResult = new CompareResult( - $this->getDataValueMock(), - array( $this->getDataValueMock() ), - false - ); - - $crossCheckResultList = new CrossCheckResultList( array( new CrossCheckResult( $this->propertyId, $this->claimGuid, $this->dumpMetaInformation, $compareResult, $this->referenceResult ) ) ); - $violations = $this->translator->translateToViolation( $this->entity, $crossCheckResultList ); - $this->assertEquals( array(), $violations ); - } - - public function testSingleViolationResult() { - $compareResult = new CompareResult( - $this->getDataValueMock(), - array( $this->getDataValueMock() ), - true - ); - - $crossCheckResultList = new CrossCheckResultList( array( new CrossCheckResult( $this->propertyId, $this->claimGuid, $this->dumpMetaInformation, $compareResult, $this->referenceResult ) ) ); - $violations = $this->translator->translateToViolation( $this->entity, $crossCheckResultList ); - $this->assertEquals( 1, sizeof( $violations ) ); - - $violation = $violations[0]; - $this->assertEquals( self::$idMap[ 'Q1' ], $violation->getEntityId() ); - $this->assertEquals( 'P1', $violation->getPropertyId()->getSerialization() ); - $this->assertEquals( $this->claimGuid, $violation->getClaimGuid() ); - $this->assertEquals( md5( $this->dumpMetaInformation->getImportDate()->format( 'YmdHis' ) . $this->dumpMetaInformation->getSourceItemId() ), $violation->getConstraintClaimGuid() ); - $this->assertEquals( $this->dumpMetaInformation->getSourceItemId(), $violation->getConstraintTypeEntityId() ); - - } - - private function getReferenceMock() { - return $this->getMock( 'Wikibase\DataModel\Reference' ); - } - - private function getDataValueMock() - { - return $this->getMock( 'DataValues\DataValue' ); - } -} \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/206514 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50194977a36fba679464ee3c87d920e62c00b296 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation Gerrit-Branch: v1 Gerrit-Owner: Jonaskeutel <jonas.keu...@student.hpi.de> Gerrit-Reviewer: Tamslo <tamaraslosa...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits