Dominic.sauer has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/206789

Change subject: Remove global scope assumptions in entry point
......................................................................

Remove global scope assumptions in entry point

Change-Id: I779cac873fae2cec105404642d2653c8e23ad617
---
M WikidataQuality.php
1 file changed, 31 insertions(+), 29 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQuality 
refs/changes/89/206789/1

diff --git a/WikidataQuality.php b/WikidataQuality.php
old mode 100644
new mode 100755
index f883f0f..49bc36a
--- a/WikidataQuality.php
+++ b/WikidataQuality.php
@@ -1,46 +1,48 @@
 <?php
 // Alert the user that this is not a valid access point to MediaWiki if they 
try to access the special pages file directly.
 if ( !defined( 'MEDIAWIKI' ) ) {
-       echo <<<EOT
+    echo <<<EOT
        To install my extension, put the following line in LocalSettings.php:
        require_once( "\$IP/extensions/WikidataQuality/WikidataQuality.php" );
 EOT;
-       exit( 1 );
+    exit( 1 );
 }
 
 // Enable autoload
 if ( file_exists( __DIR__ . '/vendor/autoload.php' ) ) {
-       require_once __DIR__ . '/vendor/autoload.php';
+    require_once __DIR__ . '/vendor/autoload.php';
 }
 
-// Set credits
-$wgExtensionCredits[ 'specialpage' ][ ] = array (
-       'path' => __FILE__,
-       'name' => 'WikidataQuality',
-       'author' => 'BP2014N1',
-       'url' => 'https://www.mediawiki.org/wiki/Extension:WikidataQuality',
-       'descriptionmsg' => 'wikidataquality-desc',
-       'version' => '0.0.0'
-);
+call_user_func( function() {
+    // Set credits
+    $GLOBALS['wgExtensionCredits']['specialpage'][] = array(
+        'path' => __FILE__,
+        'name' => 'WikidataQuality',
+        'author' => 'BP2014N1',
+        'url' => 'https://www.mediawiki.org/wiki/Extension:WikidataQuality',
+        'descriptionmsg' => 'wikidataquality-desc',
+        'version' => '0.0.0'
+    );
 
-// Initialize localization and aliases
-$wgMessagesDirs[ 'WikidataQuality' ] = __DIR__ . '/i18n';
-$wgExtensionMessagesFiles[ 'WikidataQualityAlias' ] = __DIR__ . 
'/WikidataQuality.alias.php';
+    // Initialize localization and aliases
+    $GLOBALS['wgMessagesDirs']['WikidataQuality'] = __DIR__ . '/i18n';
+    $GLOBALS['wgExtensionMessagesFiles']['WikidataQualityAlias'] = __DIR__ . 
'/WikidataQuality.alias.php';
 
-// Initalize hooks for creating database tables
-global $wgHooks;
-$wgHooks[ 'LoadExtensionSchemaUpdates' ][ ] = 
'WikidataQualityHooks::onCreateSchema';
+    // Initalize hooks for creating database tables
+    $GLOBALS['wgHooks']['LoadExtensionSchemaUpdates'][] = 
'WikidataQualityHooks::onCreateSchema';
 
-// Register hooks for Unit Tests
-$wgHooks[ 'UnitTestsList' ][ ] = 'WikidataQualityHooks::onUnitTestsList';
+    // Register hooks for Unit Tests
+    $GLOBALS['wgHooks']['UnitTestsList'][] = 
'WikidataQualityHooks::onUnitTestsList';
 
-// Define modules
-$wgResourceModules[ 'SpecialCheckResultPage' ] = array (
-       'styles' => '/modules/SpecialCheckResultPage.css',
-       'localBasePath' => __DIR__,
-       'remoteExtPath' => 'WikidataQuality'
-);
+    // Define modules
+    $GLOBALS['wgResourceModules']['SpecialCheckResultPage'] = array(
+        'styles' => '/modules/SpecialCheckResultPage.css',
+        'localBasePath' => __DIR__,
+        'remoteExtPath' => 'WikidataQuality'
+    );
 
-// Define database table names
-define( 'VIOLATION_TABLE', 'wdqa_violations' );
-define( 'EVALUATION_TABLE', 'wdqa_evaluation' );
\ No newline at end of file
+    // Define database table names
+    define( 'VIOLATION_TABLE', 'wdqa_violations' );
+    define( 'EVALUATION_TABLE', 'wdqa_evaluation' );
+
+} );
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/206789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I779cac873fae2cec105404642d2653c8e23ad617
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQuality
Gerrit-Branch: v1
Gerrit-Owner: Dominic.sauer <dominic.sa...@yahoo.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to