AndyRussG has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/206985

Change subject: Pls don't merge - WIP - 
CNBannerChoiceDataResourceLoaderModule::getDependencies() method signature
......................................................................

Pls don't merge - WIP - 
CNBannerChoiceDataResourceLoaderModule::getDependencies() method signature

This change is for compatibility with Iee61e5b527321d01287baa03ad9b4d4f526ff3ef
in core. Please don't merge until that change is approved.

Change-Id: I816bffa3815e2eab7e88cb04d1b345070e6aa15f
---
M includes/CNBannerChoiceDataResourceLoaderModule.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/85/206985/1

diff --git a/includes/CNBannerChoiceDataResourceLoaderModule.php 
b/includes/CNBannerChoiceDataResourceLoaderModule.php
index 557a4e2..2852529 100644
--- a/includes/CNBannerChoiceDataResourceLoaderModule.php
+++ b/includes/CNBannerChoiceDataResourceLoaderModule.php
@@ -121,7 +121,7 @@
        /**
         * @see ResourceLoaderModule::getDependencies()
         */
-       public function getDependencies() {
+       public function getDependencies( ResourceLoaderContext $context = null 
) {
                return array( 'ext.centralNotice.bannerController.lib' );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/206985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I816bffa3815e2eab7e88cb04d1b345070e6aa15f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <andrew.green...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to