jenkins-bot has submitted this change and it was merged.

Change subject: ApiListStudents: Use XML-friendly tag names
......................................................................


ApiListStudents: Use XML-friendly tag names

This fixes a bug following changes to ApiResult in core; see
I7b37295e8862b188d1f3b0cd07f66ac34629678f.

Bug: T97599
Change-Id: If2d82ff04a861ffc500fdd746451c6ee16a9d384
---
M includes/api/ApiListStudents.php
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Anomie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/api/ApiListStudents.php b/includes/api/ApiListStudents.php
index c5f22bd..22d5f9d 100644
--- a/includes/api/ApiListStudents.php
+++ b/includes/api/ApiListStudents.php
@@ -103,7 +103,7 @@
                                                $course,
                                                $results,
                                                $courseIndex,
-                                               'online volunteer'
+                                               'online_volunteer'
                                        );
 
                                        // List the campus volunteers
@@ -111,7 +111,7 @@
                                                $course,
                                                $results,
                                                $courseIndex,
-                                               'campus volunteer'
+                                               'campus_volunteer'
                                        );
 
                                        // List the students
@@ -185,9 +185,9 @@
 
                if ( $courseRole == 'instructor' ) {
                        $participants = $course->getInstructors();
-               } else if ( $courseRole == 'online volunteer' ) {
+               } else if ( $courseRole == 'online_volunteer' ) {
                        $participants = $course->getOnlineAmbassadors();
-               } else if ( $courseRole == 'campus volunteer' ) {
+               } else if ( $courseRole == 'campus_volunteer' ) {
                        $participants = $course->getCampusAmbassadors();
                } else if ( $courseRole == 'student' ) {
                        $participants = $course->getStudents();
@@ -621,8 +621,8 @@
 
        /**
         * Construct the results path for the element for a group
-        * (<students>, <instructors>, <online volunteers> or
-        * <campus volunters>), either as part of a numerically
+        * (<students>, <instructors>, <online_volunteers> or
+        * <campus_volunteers>), either as part of a numerically
         * indexed parent tag, or as a top-level element.
         *
         * @param int $courseIndex
@@ -638,7 +638,7 @@
 
        /**
         * Construct the results path for individual users in a course:
-        * <student>, <instructor>, <online volunteer> or <campus volunteer>.
+        * <student>, <instructor>, <online_volunteer> or <campus_volunteer>.
         *
         * @param int $courseIndex
         * @param str $userLabel

-- 
To view, visit https://gerrit.wikimedia.org/r/207778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2d82ff04a861ffc500fdd746451c6ee16a9d384
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: wmf/1.26wmf3
Gerrit-Owner: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to