Soeren.oldag has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207789
Change subject: Fixed bug to get CrossChecker working with sqlite.
......................................................................
Fixed bug to get CrossChecker working with sqlite.
Change-Id: Ibb53414a834fef5c2a4d44d7326a148bab0de9e5
---
M includes/CrossCheck/CrossChecker.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityExternalValidation
refs/changes/89/207789/1
diff --git a/includes/CrossCheck/CrossChecker.php
b/includes/CrossCheck/CrossChecker.php
index 66be68d..b4e3994 100644
--- a/includes/CrossCheck/CrossChecker.php
+++ b/includes/CrossCheck/CrossChecker.php
@@ -248,7 +248,7 @@
/**
* Creates SQL condition for WHERE clauses using the IN operator.
- * If $values is empty, true will be returned.
+ * If $values is empty, '0' will be returned.
*
* @param string $columnName
* @param array $values
@@ -266,7 +266,7 @@
return sprintf( '%s in (%s)', $columnName, implode( ',', $values )
);
} else {
- return 'false';
+ return '0';
}
}
--
To view, visit https://gerrit.wikimedia.org/r/207789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb53414a834fef5c2a4d44d7326a148bab0de9e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: v1
Gerrit-Owner: Soeren.oldag <soeren_ol...@freenet.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
