Rush has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207834
Change subject: admin group sudoers permissions cleanup
......................................................................
admin group sudoers permissions cleanup
If an empty priv array is specified now we leave
it behind on cleanup. This is disingenuous in
terms of group cleanup.
Change-Id: Ie82019144bda9296032f10ecb07ce97602cb6fea
---
M modules/admin/manifests/group.pp
1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/34/207834/1
diff --git a/modules/admin/manifests/group.pp b/modules/admin/manifests/group.pp
index 76e5bac..0b992cf 100644
--- a/modules/admin/manifests/group.pp
+++ b/modules/admin/manifests/group.pp
@@ -32,10 +32,16 @@
}
}
- if !empty($privileges) {
- sudo::group { $name:
- ensure => $ensure,
- privileges => $privileges,
- }
+ # If specified privilege is empty we manage
+ # separately from the group as a whole and cleanup
+ if empty($privileges) {
+ $privileges_ensure = 'absent'
+ } else {
+ $privileges_ensure = $ensure
+ }
+
+ sudo::group { $name:
+ ensure => $privileges_ensure,
+ privileges => $privileges,
}
}
--
To view, visit https://gerrit.wikimedia.org/r/207834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie82019144bda9296032f10ecb07ce97602cb6fea
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
