Rush has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207841
Change subject: Revert "admin group sudoers permissions cleanup"
......................................................................
Revert "admin group sudoers permissions cleanup"
This reverts commit 10c4604f7459189fd25ff157027da6bf919cceca.
Change-Id: I6ba3a3a3ff89dec80dadd7a8937bfd86d5409270
---
M modules/admin/manifests/group.pp
1 file changed, 5 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/41/207841/1
diff --git a/modules/admin/manifests/group.pp b/modules/admin/manifests/group.pp
index 0b992cf..76e5bac 100644
--- a/modules/admin/manifests/group.pp
+++ b/modules/admin/manifests/group.pp
@@ -32,16 +32,10 @@
}
}
- # If specified privilege is empty we manage
- # separately from the group as a whole and cleanup
- if empty($privileges) {
- $privileges_ensure = 'absent'
- } else {
- $privileges_ensure = $ensure
- }
-
- sudo::group { $name:
- ensure => $privileges_ensure,
- privileges => $privileges,
+ if !empty($privileges) {
+ sudo::group { $name:
+ ensure => $ensure,
+ privileges => $privileges,
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/207841
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ba3a3a3ff89dec80dadd7a8937bfd86d5409270
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
