Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/208087
Change subject: Use EntityDocument instead of Entity
......................................................................
Use EntityDocument instead of Entity
The call in getRequiredPermissions was unsafe before this change
Change-Id: I20b45c6ede98c7f01fc75d699b1bc79129536010
---
M repo/includes/api/ApiWikibase.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/87/208087/1
diff --git a/repo/includes/api/ApiWikibase.php
b/repo/includes/api/ApiWikibase.php
index e44ef29..af33e71 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -169,11 +169,11 @@
}
/**
- * @param Entity $entity
+ * @param EntityDocument $entity
*
* @return bool
*/
- protected function entityExists( Entity $entity ) {
+ protected function entityExists( EntityDocument $entity ) {
$entityId = $entity->getId();
$title = $entityId === null ? null :
$this->titleLookup->getTitleForId( $entityId );
return ( $title !== null && $title->exists() );
--
To view, visit https://gerrit.wikimedia.org/r/208087
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20b45c6ede98c7f01fc75d699b1bc79129536010
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
