Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/208142
Change subject: To be honest, I do not quite remember everything I changed here
today. But it is all good, I tell ya.
......................................................................
To be honest, I do not quite remember everything I changed here today. But it
is all good, I tell ya.
Change-Id: Idf708979ff3b54948fd6ef7d027ab9a46a363d0e
---
M repo/tests/phpunit/includes/store/sql/EntityPerPageTableTest.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/42/208142/1
diff --git a/repo/tests/phpunit/includes/store/sql/EntityPerPageTableTest.php
b/repo/tests/phpunit/includes/store/sql/EntityPerPageTableTest.php
index 673bcff..09565a2 100644
--- a/repo/tests/phpunit/includes/store/sql/EntityPerPageTableTest.php
+++ b/repo/tests/phpunit/includes/store/sql/EntityPerPageTableTest.php
@@ -3,7 +3,7 @@
namespace Wikibase\Test;
use Wikibase\DataModel\Entity\BasicEntityIdParser;
-use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\Property;
@@ -67,7 +67,7 @@
}
/**
- * @param Entity[] $entities
+ * @param EntityDocument[] $entities
*
* @return EntityPerPageTable
*/
@@ -107,7 +107,7 @@
protected function getIdStrings( array $entities ) {
$ids = array_map( function ( $entity ) {
- if ( $entity instanceof Entity ) {
+ if ( $entity instanceof EntityDocument ) {
$entity = $entity->getId();
}
return $entity->getSerialization();
--
To view, visit https://gerrit.wikimedia.org/r/208142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf708979ff3b54948fd6ef7d027ab9a46a363d0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
