jenkins-bot has submitted this change and it was merged.
Change subject: Remove duplicate listUnattached() check
......................................................................
Remove duplicate listUnattached() check
The conditional on line 432 ensures that the conditional on line 446
would always return false if the line was reachable.
Change-Id: I977fa2a847174a8423e599b1dc433965b256adc4
---
M includes/GlobalRename/GlobalRenameRequest.php
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/GlobalRename/GlobalRenameRequest.php
b/includes/GlobalRename/GlobalRenameRequest.php
index 5a94267..4ae7f40 100644
--- a/includes/GlobalRename/GlobalRenameRequest.php
+++ b/includes/GlobalRename/GlobalRenameRequest.php
@@ -441,13 +441,6 @@
return $status;
}
- // Check to see if there are unattached accounts in the wiki
family
- // that would clash with the desired name.
- if ( $centralUser->listUnattached() ) {
- $status->fatal( 'globalrenamerequest-newname-err-taken'
);
- return $status;
- }
-
return $status;
}
--
To view, visit https://gerrit.wikimedia.org/r/208159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I977fa2a847174a8423e599b1dc433965b256adc4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
