Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/208310
Change subject: Make browser location bar reflect current query ...................................................................... Make browser location bar reflect current query Since this is a POST request we can't easily show the data in the browser bar. This never worked properly, though before beb5d5b it did preserve the first query from a permalink (any subsequent query continued to show the first one in the address bar). Also: * Remove Prototype.js. Use plain javascript instead with a feature test for unsupported browsers. The fallback without javascript works fine. * Use event handlers instead of onclick="" evaluation attributes. Bug: T97756 Change-Id: I0b62573fec2890792de5dfa134e1f1648440f58f --- M ResourceLoaderGeSHiLocalModule.php M ResourceLoaderGeSHiModule.php 2 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi refs/changes/10/208310/1 diff --git a/ResourceLoaderGeSHiLocalModule.php b/ResourceLoaderGeSHiLocalModule.php index 7ce87b5..ce62224 100644 --- a/ResourceLoaderGeSHiLocalModule.php +++ b/ResourceLoaderGeSHiLocalModule.php @@ -26,12 +26,12 @@ */ protected function getPages( ResourceLoaderContext $context ) { global $wgUseSiteCss; - if ( $wgUseSiteCss ) { - return array( - 'MediaWiki:Geshi.css' => array( 'type' => 'style' ), - ); - } else { + if ( !$wgUseSiteCss ) { return array(); } + + return array( + 'MediaWiki:Geshi.css' => array( 'type' => 'style' ), + ); } } diff --git a/ResourceLoaderGeSHiModule.php b/ResourceLoaderGeSHiModule.php index 98c1c1e..87e0534 100644 --- a/ResourceLoaderGeSHiModule.php +++ b/ResourceLoaderGeSHiModule.php @@ -70,10 +70,11 @@ * @return array */ public function getDefinitionSummary( ResourceLoaderContext $context ) { - return array( - 'class' => get_class( $this ), + $summary = parent::getDefinitionSummary(); + $summary[] = array( 'lang' => $this->lang, 'geshi' => GESHI_VERSION, ); + return $summary; } } -- To view, visit https://gerrit.wikimedia.org/r/208310 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0b62573fec2890792de5dfa134e1f1648440f58f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits