jenkins-bot has submitted this change and it was merged. Change subject: Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client ......................................................................
Follow-up cc5ca3a2f6: now that we sample client-side, send all editingStatsIds to the client If the server-generated editingStatsId was sampled out, we never sent it to the client. This made this code confusing and difficult to test, but it also caused a bug: the client-generated editingStatsId (for when the user presses back) has no place to go in that case, and gets dropped on the floor. Bug: T95919 Change-Id: I05adb7116f1a8b91a9e54dfa70c745f12d7fbf3c (cherry picked from commit bfae89b9e0bb9bf44b029be27817e1544399f258) --- M WikiEditor.hooks.php 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/WikiEditor.hooks.php b/WikiEditor.hooks.php index 0ce923a..9f0adb1 100644 --- a/WikiEditor.hooks.php +++ b/WikiEditor.hooks.php @@ -261,10 +261,6 @@ if ( !$editingStatsId || !$req->wasPosted() ) { $editingStatsId = self::getEditingStatsId(); } - // Sample 25% (via hex digit) - if ( $editingStatsId[0] > '3' ) { - return true; - } $outputPage->addHTML( Xml::element( -- To view, visit https://gerrit.wikimedia.org/r/208324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05adb7116f1a8b91a9e54dfa70c745f12d7fbf3c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiEditor Gerrit-Branch: wmf/1.26wmf4 Gerrit-Owner: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits