jenkins-bot has submitted this change and it was merged.
Change subject: Removed mwoauthmanageconsumers-viewing message
......................................................................
Removed mwoauthmanageconsumers-viewing message
* There is not enough traffic for this to be useful
Change-Id: Ifb1b98a4665351c63508dc0bdf2bdadcd14b8a89
---
M frontend/specialpages/SpecialMWOAuthManageConsumers.php
M i18n/en.json
2 files changed, 0 insertions(+), 16 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/frontend/specialpages/SpecialMWOAuthManageConsumers.php
b/frontend/specialpages/SpecialMWOAuthManageConsumers.php
old mode 100644
new mode 100755
index b759c75..c45105c
--- a/frontend/specialpages/SpecialMWOAuthManageConsumers.php
+++ b/frontend/specialpages/SpecialMWOAuthManageConsumers.php
@@ -208,8 +208,6 @@
* @throws \PermissionsError
*/
protected function handleConsumerForm( $consumerKey ) {
- global $wgMemc;
-
$user = $this->getUser();
$lang = $this->getLanguage();
$dbr = MWOAuthUtils::getCentralDB( DB_SLAVE );
@@ -406,9 +404,6 @@
'flags' =>
\LogEventsList::NO_EXTRA_USER_LINKS
)
);
- // Set a key to who is looking at this request
- $key = wfMemcKey( 'mwoauth', 'manageconsumers', 'view',
$cmr->get( 'id' ) );
- $wgMemc->set( $key, $user->getID(), 60 * 5 );
}
}
@@ -439,8 +434,6 @@
* @return string
*/
public function formatRow( \DBConnRef $db, $row ) {
- global $wgMemc;
-
static $stageActionMap = array(
MWOAuthConsumer::STAGE_PROPOSED => 'propose',
MWOAuthConsumer::STAGE_REJECTED => 'reject',
@@ -480,14 +473,6 @@
'flags' => \LogEventsList::NO_EXTRA_USER_LINKS
)
);
-
- // Check if someone is viewing this request now
- $key = wfMemcKey( 'mwoauth', 'manageconsumers', 'view',
$cmr->get( 'id' ) );
- $value = $wgMemc->get( $key );
- if ( $value ) {
- $r .= ' <b>' . $this->msg(
'mwoauthmanageconsumers-viewing',
- \User::whoIs( $value ) )->parse() . '</b>';
- }
$lang = $this->getLanguage();
$data = array(
diff --git a/i18n/en.json b/i18n/en.json
index da808a5..f40a361 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -119,7 +119,6 @@
"mwoauthmanageconsumers-reenable": "Approved",
"mwoauthmanageconsumers-reason": "Reason:",
"mwoauthmanageconsumers-confirm-submit": "Update consumer status",
- "mwoauthmanageconsumers-viewing": "{{GENDER:$1|User}} \"$1\" is
currently viewing this consumer",
"mwoauthmanageconsumers-success-approved": "Request has been approved.",
"mwoauthmanageconsumers-success-rejected": "Request has been rejected.",
"mwoauthmanageconsumers-success-disabled": "Consumer has been
disabled.",
--
To view, visit https://gerrit.wikimedia.org/r/207849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1b98a4665351c63508dc0bdf2bdadcd14b8a89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
