jenkins-bot has submitted this change and it was merged.
Change subject: Add empty span for indicators to the snakview
......................................................................
Add empty span for indicators to the snakview
Advantages of this solution:
* It works everywhere, in main snaks, qualifiers and references.
* It's independent from the skin and the planned redesign because it
simply inlines smoothly with the value.
Disadvantages:
* It's the same class name for all indicator elements. You need a good
CSS selector to target the correct element. Shouldn't be that hard:
start with the statement GUID and then go deeper, possibly using ">"
in the selector.
* The icons are not aligned. They are simply appended to the end of
the values.
* There is no default padding. Each icon added to the empty element
should come with a good padding that works in both LTR and RTL
contexts, e.g. "padding: 0 0.5em".
Bug: T95403
Change-Id: I8250979fd105f2b9a3eb1c4ab188e3df15bfcd1a
---
M view/resources/templates.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/resources/templates.php b/view/resources/templates.php
index 627acb5..0633a43 100644
--- a/view/resources/templates.php
+++ b/view/resources/templates.php
@@ -70,7 +70,7 @@
</div>
<div class="wikibase-snakview-value-container" dir="auto">
<div class="wikibase-snakview-typeselector"></div>
- <div class="wikibase-snakview-value $2">$3</div>
+ <div class="wikibase-snakview-value $2">$3<span
class="wb-indicator"></span></div>
</div>
</div>
HTML;
--
To view, visit https://gerrit.wikimedia.org/r/207449
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8250979fd105f2b9a3eb1c4ab188e3df15bfcd1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
