Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208978

Change subject: Explicitly define module position
......................................................................

Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I269853c8648b48a07d361ed325e28207aa1b11fc
---
M CologneBlue.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/CologneBlue 
refs/changes/78/208978/1

diff --git a/CologneBlue.php b/CologneBlue.php
index 4f1d7a8..6e04f60 100644
--- a/CologneBlue.php
+++ b/CologneBlue.php
@@ -41,6 +41,7 @@
 
 // Register modules
 $wgResourceModules['skins.cologneblue'] = array(
+       'position' => 'top',
        'styles' => array(
                'resources/screen.css' => array( 'media' => 'screen' ),
                'resources/print.css' => array( 'media' => 'print' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/208978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I269853c8648b48a07d361ed325e28207aa1b11fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/CologneBlue
Gerrit-Branch: master
Gerrit-Owner: Gilles <gdu...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to