Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208981

Change subject: Explicitly define module position
......................................................................

Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I2e8288edcf0837b855665710eb417f743001fec1
---
M Modern.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Modern 
refs/changes/81/208981/1

diff --git a/Modern.php b/Modern.php
index f5b3013..93eef8c 100644
--- a/Modern.php
+++ b/Modern.php
@@ -41,6 +41,7 @@
 
 // Register modules
 $wgResourceModules['skins.modern'] = array(
+       'position' => 'top',
        'styles' => array(
                'resources/main.css' => array( 'media' => 'screen' ),
                'resources/print.css' => array( 'media' => 'print' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/208981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e8288edcf0837b855665710eb417f743001fec1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Modern
Gerrit-Branch: master
Gerrit-Owner: Gilles <gdu...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to