jenkins-bot has submitted this change and it was merged. Change subject: Allow ios users to close the main menu ......................................................................
Allow ios users to close the main menu Bug: T97621 Change-Id: I2b8d16e5ccf9df44ab779512c14d7ce32e0c4b9e (cherry picked from commit a8626d210516ae4da30c6b417c66325ba293f9f7) --- M resources/mobile.startup/Skin.js 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Robmoen: Looks good to me, approved Kaldari: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mobile.startup/Skin.js b/resources/mobile.startup/Skin.js index 0ec4ca5..1849160 100644 --- a/resources/mobile.startup/Skin.js +++ b/resources/mobile.startup/Skin.js @@ -29,9 +29,7 @@ /** * @inheritdoc */ - events: { - 'click #mw-mf-page-center': '_onPageCenterClick' - }, + events: {}, /** * Close navigation if content tapped @@ -136,6 +134,9 @@ * Fired when appearance of skin changes. */ this.emit( 'changed' ); + // FIXME: Move back into events when T98200 resolved + this.$( '#mw-mf-page-center' ).on( 'click', + $.proxy( this, '_onPageCenterClick' ) ); }, /** -- To view, visit https://gerrit.wikimedia.org/r/209323 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b8d16e5ccf9df44ab779512c14d7ce32e0c4b9e Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: wmf/1.26wmf4 Gerrit-Owner: Robmoen <rm...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org> Gerrit-Reviewer: Robmoen <rm...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits