jenkins-bot has submitted this change and it was merged.

Change subject: Ensure collection members can be removed
......................................................................


Ensure collection members can be removed

Due to api inconsistency (thought I fixed this in previous patchset
by using formatversion but apparently not)

Bug: T98448
Change-Id: I7a8d03ccf834bfabf01d0df658a6cebee8687af1
(cherry picked from commit 9939e043003fdd5e21ae32cc1e1dea649f69b626)
---
M resources/ext.gather.api/CollectionsApi.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Robmoen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ext.gather.api/CollectionsApi.js 
b/resources/ext.gather.api/CollectionsApi.js
index db99169..e8a1804 100644
--- a/resources/ext.gather.api/CollectionsApi.js
+++ b/resources/ext.gather.api/CollectionsApi.js
@@ -144,7 +144,7 @@
                _mapCollection: function ( list ) {
                        // FIXME: API should handle all these inconsistencies.
                        list.isWatchlist = list.watchlist !== undefined;
-                       list.titleInCollection = list.title;
+                       list.titleInCollection = list.title !== undefined;
                        list.title = list.label;
                        list.owner = list.owner;
                        list.isPublic = list.perm === 'public';

-- 
To view, visit https://gerrit.wikimedia.org/r/209619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a8d03ccf834bfabf01d0df658a6cebee8687af1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: wmf/1.26wmf5
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Robmoen <rm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to