Yuvipanda has submitted this change and it was merged.
Change subject: tools: Fix broken continuous job checks
......................................................................
tools: Fix broken continuous job checks
Change-Id: Id8428e77df0bafdbff0fd47d2a89975927bf5453
---
M modules/toollabs/files/toolschecker.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yuvipanda: Verified; Looks good to me, approved
diff --git a/modules/toollabs/files/toolschecker.py
b/modules/toollabs/files/toolschecker.py
index 480565d..f3865f7 100644
--- a/modules/toollabs/files/toolschecker.py
+++ b/modules/toollabs/files/toolschecker.py
@@ -57,7 +57,8 @@
def job_running(name):
"""Check if a job with given name is running"""
try:
- subprocess.check_call(['/usr/bin/qstat', '-j', name],
stdout=os.devnull)
+ with open(os.devnull, 'w') as devnull:
+ subprocess.check_call(['/usr/bin/qstat', '-j', name], devnull)
return True
except subprocess.CalledProcessError:
return False
--
To view, visit https://gerrit.wikimedia.org/r/209663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8428e77df0bafdbff0fd47d2a89975927bf5453
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
