Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209725
Change subject: Fix Notice: Undefined index: title error
......................................................................
Fix Notice: Undefined index: title error
... in SpecialTopicTag#executeWhenAvailable
Test if the title key is present before accessing it. The key might not
be present if there's a problem looking up the title.
This was discovered while testing T94744.
Change-Id: I13acc363a48e3f4940e54b9eab24b8c04c4ce32f
---
M includes/specials/browse/SpecialTopicTag.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/25/209725/1
diff --git a/includes/specials/browse/SpecialTopicTag.php
b/includes/specials/browse/SpecialTopicTag.php
index a6e1382..1bb2909 100644
--- a/includes/specials/browse/SpecialTopicTag.php
+++ b/includes/specials/browse/SpecialTopicTag.php
@@ -69,7 +69,7 @@
$pages = $this->getPages( $pageIds );
if ( $pages ) {
foreach ( $pages as $page ) {
- if ( !$page['title'] ) {
+ if ( !isset( $page['title'] ) ||
!$page['title'] ) {
continue;
}
$title = Title::newFromText( $page['title'] );
--
To view, visit https://gerrit.wikimedia.org/r/209725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13acc363a48e3f4940e54b9eab24b8c04c4ce32f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <g...@samsmith.io>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
