Phuedx has uploaded a new change for review. https://gerrit.wikimedia.org/r/209731
Change subject: Hygiene: Stop logging in watchstar tests ...................................................................... Hygiene: Stop logging in watchstar tests Stub MobileWebWatching.prototype.log, i.e. Schema.log. Change-Id: I7690f2cc170ce209ad147d5fe98f588fc2b191aa --- M tests/qunit/mobile.watchstar/test_Watchstar.js 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/31/209731/1 diff --git a/tests/qunit/mobile.watchstar/test_Watchstar.js b/tests/qunit/mobile.watchstar/test_Watchstar.js index d4fab2b..7e075d1 100644 --- a/tests/qunit/mobile.watchstar/test_Watchstar.js +++ b/tests/qunit/mobile.watchstar/test_Watchstar.js @@ -9,7 +9,8 @@ name: 'watched' } ), user = M.require( 'user' ), - Page = M.require( 'Page' ); + Page = M.require( 'Page' ), + SchemaMobileWebWatching = M.require( 'loggingSchemas/SchemaMobileWebWatching' ); QUnit.module( 'MobileFrontend: Watchstar.js Anon', { setup: function () { @@ -38,6 +39,9 @@ this.sandbox.stub( user, 'isAnon' ).returns( false ); this.spy = this.sandbox.stub( WatchstarApi.prototype, 'postWithToken' ) .returns( $.Deferred().resolve() ); + + // FIXME: Should Schema.log be stubbed by default? + this.stub( SchemaMobileWebWatching.prototype, 'log' ).returns( null ); }, teardown: function () { // Hide any existing toasts -- To view, visit https://gerrit.wikimedia.org/r/209731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7690f2cc170ce209ad147d5fe98f588fc2b191aa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Phuedx <g...@samsmith.io> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits