Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209733
Change subject: Toolbar: Remove some useless code from the example
......................................................................
Toolbar: Remove some useless code from the example
There is actually no reason to call this.setActive( false ) here.
Change-Id: Ia050249dd42d59f60900d1cc9a2d5cf524a67585
---
M src/Toolbar.js
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/33/209733/1
diff --git a/src/Toolbar.js b/src/Toolbar.js
index 17a8a40..99e6150 100644
--- a/src/Toolbar.js
+++ b/src/Toolbar.js
@@ -33,7 +33,6 @@
* // editor's editing area, highlighting the tools (e.g. a 'bold' tool
would be shown as active
* // when the text cursor was inside bolded text). Here we simply disable
this feature.
* PictureTool.prototype.onUpdateState = function () {
- * this.setActive( false );
* };
* // Make this tool available in our toolFactory and thus our toolbar
* toolFactory.register( PictureTool );
@@ -51,7 +50,6 @@
* this.setActive( false );
* };
* SettingsTool.prototype.onUpdateState = function () {
- * this.setActive( false );
* };
* toolFactory.register( SettingsTool );
*
@@ -68,7 +66,6 @@
* this.setActive( false );
* };
* StuffTool.prototype.onUpdateState = function () {
- * this.setActive( false );
* };
* toolFactory.register( StuffTool );
*
--
To view, visit https://gerrit.wikimedia.org/r/209733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia050249dd42d59f60900d1cc9a2d5cf524a67585
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
