BearND has submitted this change and it was merged. Change subject: Prefix JSON metadata embed id with "mw-" ......................................................................
Prefix JSON metadata embed id with "mw-" Follow up to comment on https://gerrit.wikimedia.org/r/#/c/209808/2/routes/mobileapp-page.js Change-Id: I9d3c1952b74855a7a6b4352b579f3495e824450d --- M routes/mobileapp-page.js M www/bundle.js M www/js/meta.js 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: BearND: Verified GWicke: Looks good to me, approved diff --git a/routes/mobileapp-page.js b/routes/mobileapp-page.js index ae3bb65..c0a110e 100644 --- a/routes/mobileapp-page.js +++ b/routes/mobileapp-page.js @@ -275,7 +275,7 @@ body.setAttribute("class", "stable"); - body.appendChild(embedJsScriptInHtml(doc, "app_meta1", meta1)); + body.appendChild(embedJsScriptInHtml(doc, "mw-app-meta1", meta1)); var contentDiv = doc.createElement("div"); contentDiv.setAttribute("id", "content"); @@ -292,7 +292,7 @@ contentDiv.innerHTML = contentDiv.innerHTML + section.text; } - body.appendChild(embedJsScriptInHtml(doc, "app_meta2", meta2)); + body.appendChild(embedJsScriptInHtml(doc, "mw-app-meta2", meta2)); return doc.outerHTML; } diff --git a/www/bundle.js b/www/bundle.js index af80ce5..acc87ed 100644 --- a/www/bundle.js +++ b/www/bundle.js @@ -293,11 +293,11 @@ }; document.addEventListener( 'DOMContentLoaded', function(event) { - sendAppMetaData( 'onGetAppMeta1', 'app_meta1' ); + sendAppMetaData( 'onGetAppMeta1', 'mw-app-meta1' ); }); bridge.registerListener( 'getAppMeta2', function() { - sendAppMetaData( 'onGetAppMeta2', 'app_meta2' ); + sendAppMetaData( 'onGetAppMeta2', 'mw-app-meta2' ); }); },{"./bridge":2}],9:[function(require,module,exports){ diff --git a/www/js/meta.js b/www/js/meta.js index d29e91c..ecb2d3f 100644 --- a/www/js/meta.js +++ b/www/js/meta.js @@ -5,9 +5,9 @@ }; document.addEventListener( 'DOMContentLoaded', function(event) { - sendAppMetaData( 'onGetAppMeta1', 'app_meta1' ); + sendAppMetaData( 'onGetAppMeta1', 'mw-app-meta1' ); }); bridge.registerListener( 'getAppMeta2', function() { - sendAppMetaData( 'onGetAppMeta2', 'app_meta2' ); + sendAppMetaData( 'onGetAppMeta2', 'mw-app-meta2' ); }); -- To view, visit https://gerrit.wikimedia.org/r/209815 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d3c1952b74855a7a6b4352b579f3495e824450d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/mobileapps Gerrit-Branch: master Gerrit-Owner: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: GWicke <gwi...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
