Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/209870

Change subject: Don't output an empty h1 element
......................................................................

Don't output an empty h1 element

Bug: T97891
Change-Id: Iad1fec58773e42b66030bff505113e43e66e807f
---
M VectorTemplate.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/70/209870/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 1437fa6..fbf1efe 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -106,12 +106,14 @@
                        if ( is_callable( array( $this, 'getIndicators' ) ) ) {
                                echo $this->getIndicators();
                        }
+                       if ( !empty( $this->data['title'] ) ) {
                        ?>
                        <h1 id="firstHeading" class="firstHeading" lang="<?php
                        $this->data['pageLanguage'] =
                                
$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
                        $this->text( 'pageLanguage' );
                        ?>"><?php $this->html( 'title' ) ?></h1>
+                       <?php } ?>
                        <?php $this->html( 'prebodyhtml' ) ?>
                        <div id="bodyContent" class="mw-body-content">
                                <?php

-- 
To view, visit https://gerrit.wikimedia.org/r/209870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad1fec58773e42b66030bff505113e43e66e807f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to