jenkins-bot has submitted this change and it was merged. Change subject: TextInputWidget: Use aria-required along with the required attribute ......................................................................
TextInputWidget: Use aria-required along with the required attribute MDN says: > HTML5 now has the required attribute, but aria-required is still useful for user agents that do not yet support HTML5 (from https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-required_attribute) Change-Id: I1316751f852b30dbbd580d3120f9c89f70acad3f --- M php/widgets/TextInputWidget.php M src/widgets/TextInputWidget.js 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jforrester: Looks good to me, but someone else must approve TheDJ: Looks good to me, approved jenkins-bot: Verified diff --git a/php/widgets/TextInputWidget.php b/php/widgets/TextInputWidget.php index 882e557..a5f31f7 100644 --- a/php/widgets/TextInputWidget.php +++ b/php/widgets/TextInputWidget.php @@ -67,7 +67,7 @@ $this->input->setAttributes( array( 'autofocus' => 'autofocus' ) ); } if ( $config['required'] ) { - $this->input->setAttributes( array( 'required' => 'required' ) ); + $this->input->setAttributes( array( 'required' => 'required', 'aria-required' => 'true' ) ); } } @@ -142,7 +142,8 @@ $config['autofocus'] = true; } $required = $this->input->getAttribute( 'required' ); - if ( $required !== null ) { + $ariarequired = $this->input->getAttribute( 'aria-required' ); + if ( ( $required !== null ) || ( $ariarequired !== null ) ) { $config['required'] = true; } return parent::getConfig( $config ); diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js index c4cbec0..fe92f2d 100644 --- a/src/widgets/TextInputWidget.js +++ b/src/widgets/TextInputWidget.js @@ -110,6 +110,7 @@ } if ( config.required ) { this.$input.attr( 'required', 'required' ); + this.$input.attr( 'aria-required', 'true' ); } if ( this.label || config.autosize ) { this.installParentChangeDetector(); -- To view, visit https://gerrit.wikimedia.org/r/208593 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1316751f852b30dbbd580d3120f9c89f70acad3f Gerrit-PatchSet: 2 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Prtksxna <[email protected]> Gerrit-Reviewer: Bartosz Dziewoński <[email protected]> Gerrit-Reviewer: Jforrester <[email protected]> Gerrit-Reviewer: TheDJ <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
