Bgerstle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/210206

Change subject: bump fastlane to 1.0, simplify fastfile
......................................................................

bump fastlane to 1.0, simplify fastfile

- Remove calls to produce (app records already exist)
- Keep test actions in separate lane, and chain them manually in Jenkins

I basically moved our fastlane folder to a tmp location, re-ran fastlane
init, and added lanes for other configs/app-ids.

Change-Id: Iab9e2f32f1a41f4b7a6b75db47948aa2f3047a9e
---
M Gemfile
M Gemfile.lock
A fastlane/.env
D fastlane/Android
M fastlane/Appfile
M fastlane/Deliverfile
M fastlane/Fastfile
D fastlane/Snapfile
D fastlane/SnapshotHelper.js
D fastlane/deliver/metadata.json
M fastlane/lib/utils.rb
A fastlane/metadata/en-US/description.txt
A fastlane/metadata/en-US/keywords.txt
A fastlane/metadata/en-US/privacy_url.txt
A fastlane/metadata/en-US/software_url.txt
A fastlane/metadata/en-US/support_url.txt
A fastlane/metadata/en-US/title.txt
A fastlane/metadata/en-US/version_whats_new.txt
D fastlane/snapshot-iPad.js
D fastlane/snapshot.js
20 files changed, 273 insertions(+), 388 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/06/210206/1

diff --git a/Gemfile b/Gemfile
index 5b621c6..23be19d 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,5 +1,5 @@
 source "https://rubygems.org";
 
 gem 'cocoapods', '~> 0.36.1'
-gem 'fastlane', '~> 0.12.0'
-gem 'git', '= 1.2.8'
+gem 'fastlane', '~> 1.0.2'
+gem 'git', '~> 1.2'
diff --git a/Gemfile.lock b/Gemfile.lock
index 76c7ce4..b88636f 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -20,8 +20,8 @@
       rack (>= 1.0.0)
       rack-test (>= 0.5.4)
       xpath (~> 2.0)
-    cert (0.1.9)
-      fastlane_core (>= 0.6.0)
+    cert (0.2.0)
+      fastlane_core (>= 0.7.2)
     certified (1.0.0)
     claide (0.8.1)
     cliver (0.3.2)
@@ -51,9 +51,9 @@
       netrc (= 0.7.8)
     cocoapods-try (0.4.3)
     colored (1.2)
-    commander (4.3.3)
+    commander (4.3.4)
       highline (~> 1.7.2)
-    credentials_manager (0.3.0)
+    credentials_manager (0.4.0)
       colored
       highline (>= 1.7.1)
       security
@@ -66,7 +66,7 @@
       security (~> 0.1.2)
       term-ansicolor (~> 1.0.7)
       terminal-table (~> 1.4.5)
-    deliver (0.9.3)
+    deliver (0.9.4)
       credentials_manager (>= 0.3.0)
       excon
       fastimage (~> 1.6.3)
@@ -77,9 +77,7 @@
       rubyzip (~> 1.1.6)
     domain_name (0.5.24)
       unf (>= 0.0.5, < 1.0.0)
-    dotenv (0.11.1)
-      dotenv-deployment (~> 0.0.2)
-    dotenv-deployment (0.0.2)
+    dotenv (2.0.1)
     escape (0.0.4)
     excon (0.45.3)
     faraday (0.8.9)
@@ -88,30 +86,30 @@
       faraday (>= 0.7.4, < 0.10)
     fastimage (1.6.8)
       addressable (~> 2.3, >= 2.3.5)
-    fastlane (0.12.5)
+    fastlane (1.0.2)
       aws-sdk (~> 1.0)
-      cert (>= 0.1.7)
+      cert (>= 0.2.0)
       cupertino (>= 1.3.3)
-      deliver (>= 0.9.3)
-      fastlane_core (>= 0.6.2)
-      frameit (>= 1.0.0)
+      deliver (>= 0.9.4)
+      fastlane_core (>= 0.7.2)
+      frameit (>= 1.0.1)
+      krausefx-shenzhen (= 0.14.2)
       nokogiri (~> 1.6)
-      pem (>= 0.5.4)
-      produce (>= 0.2.0)
-      shenzhen (~> 0.12)
-      sigh (>= 0.4.10)
+      pem (>= 0.5.5)
+      produce (>= 0.2.1)
+      sigh (>= 0.5.1)
       slack-notifier (~> 1.0)
-      snapshot (>= 0.7.0)
+      snapshot (>= 0.8.0)
       terminal-notifier (~> 1.6.2)
       terminal-table (~> 1.4.5)
       xcodeproj (~> 0.20)
       xcpretty (~> 0.1)
-    fastlane_core (0.6.2)
+    fastlane_core (0.7.2)
       babosa
       capybara (~> 2.4.3)
       colored
-      commander (>= 4.1.0)
-      credentials_manager (>= 0.2.1)
+      commander (>= 4.3.4)
+      credentials_manager (>= 0.4.0)
       excon (~> 0.45.0)
       highline (>= 1.7.2)
       json
@@ -124,10 +122,23 @@
       fastlane_core (>= 0.5.0)
       mini_magick (~> 4.0.2)
     fuzzy_match (2.0.4)
-    git (1.2.8)
+    git (1.2.9.1)
     highline (1.7.2)
     i18n (0.7.0)
     json (1.8.2)
+    krausefx-shenzhen (0.14.2)
+      aws-sdk (~> 1.0)
+      commander (~> 4.3)
+      dotenv (>= 0.7)
+      faraday (~> 0.8.9)
+      faraday_middleware (~> 0.9)
+      highline (>= 1.7.2)
+      json (~> 1.8)
+      net-sftp (~> 2.1.2)
+      plist (~> 3.1.0)
+      rubyzip (~> 1.1)
+      security (~> 0.1.3)
+      terminal-table (~> 1.4.5)
     mechanize (2.5.1)
       domain_name (~> 0.5, >= 0.5.1)
       mime-types (~> 1.17, >= 1.17.2)
@@ -155,7 +166,7 @@
     ntlm-http (0.1.1)
     open4 (1.3.4)
     pdf-core (0.5.1)
-    pem (0.5.4)
+    pem (0.5.5)
       fastlane_core (>= 0.6.0)
     phantomjs (1.9.8.0)
     plist (3.1.0)
@@ -167,31 +178,18 @@
     prawn (2.0.1)
       pdf-core (~> 0.5.1)
       ttfunk (~> 1.4.0)
-    produce (0.2.0)
+    produce (0.2.1)
       fastlane_core (>= 0.5.0)
-    rack (1.6.0)
+    rack (1.6.1)
     rack-test (0.6.3)
       rack (>= 1.0)
     rubyzip (1.1.7)
     security (0.1.3)
-    shenzhen (0.14.0)
-      aws-sdk (~> 1.0)
-      commander (~> 4.3)
-      dotenv (~> 0.7)
-      faraday (~> 0.8.9)
-      faraday_middleware (~> 0.9)
-      highline (>= 1.7.1)
-      json (~> 1.8)
-      net-sftp (~> 2.1.2)
-      plist (~> 3.1.0)
-      rubyzip (~> 1.1)
-      security (~> 0.1.3)
-      terminal-table (~> 1.4.5)
-    sigh (0.4.10)
-      fastlane_core (>= 0.6.0)
+    sigh (0.5.1)
+      fastlane_core (>= 0.7.2)
       plist (~> 3.1.0)
     slack-notifier (1.2.0)
-    snapshot (0.7.1)
+    snapshot (0.8.0)
       fastimage (~> 1.6.3)
       fastlane_core (>= 0.5.0)
     term-ansicolor (1.0.7)
@@ -220,5 +218,5 @@
 
 DEPENDENCIES
   cocoapods (~> 0.36.1)
-  fastlane (~> 0.12.0)
-  git (= 1.2.8)
+  fastlane (~> 1.0.2)
+  git (~> 1.2)
diff --git a/fastlane/.env b/fastlane/.env
new file mode 100644
index 0000000..0302e9a
--- /dev/null
+++ b/fastlane/.env
@@ -0,0 +1,4 @@
+export IPA_WORKSPACE='Wikipedia.xcworkspace'
+export IPA_CLEAN=1
+export IPA_ARCHIVE=1
+export IPA_DESTINATION='build'
diff --git a/fastlane/Android b/fastlane/Android
deleted file mode 100644
index e69de29..0000000
--- a/fastlane/Android
+++ /dev/null
diff --git a/fastlane/Appfile b/fastlane/Appfile
index 6496604..668b8bd 100644
--- a/fastlane/Appfile
+++ b/fastlane/Appfile
@@ -1,7 +1,16 @@
-
+# vi: ft=ruby
 # Team
 team_id "AKK7J2GV64"
 team_name "Wikimedia Foundation"
 
-# Account to use to submit builds
-apple_id ENV['WMF_APPLE_USER_NAME']
+for_lane 'ios alpha' do
+  app_identifier "org.wikimedia.wikipedia.tfalpha"
+end
+
+for_lane 'ios beta' do
+  app_identifier "org.wikimedia.wikipedia.tfbeta"
+end
+
+for_lane 'ios store' do
+  app_identifier "org.wikimedia.wikipedia"
+end
diff --git a/fastlane/Deliverfile b/fastlane/Deliverfile
index 9a0ce06..540ea2b 100644
--- a/fastlane/Deliverfile
+++ b/fastlane/Deliverfile
@@ -1,29 +1,33 @@
-# For more information about each property, visit the GitHub documentation: 
https://github.com/krausefx/deliver
-# Everything next to a # is a comment and will be ignored
-# vim: ft=ruby
+# vi: ft=ruby
+###################### App Metadata ######################
+# Update the app description and metadata in the ./metadata folder
 
-# hide_transporter_output # remove the '#' in the beginning of the line, to 
hide the output while uploading
+###################### Screenshots ######################
+# Store all screenshots in the ./screenshots folder separated
+# by language. If you use snapshot, this happens automatically
 
-# Tell deliver to use ENV vars populated by ipa action
-ipa ENV["IPA_OUTPUT_PATH"]
-beta_ipa ENV["IPA_OUTPUT_PATH"]
+###################### IPA File ######################
+# This part is only relevant, if you want to submit a new binary
+# If you don't use fastlane (https://github.com/KrauseFx/fastlane)
+# you can set the path to your ipa file using:
+# ipa "./app.ipa"
 
+# to provide an ipa file for TestFlight distribution, use beta_ipa
+# beta_ipa "./app.ipa"
 
-########################################
-# App Metadata
-########################################
+###################### More Options ######################
+# If you want to have even more control, check out the documentation
+# https://github.com/KrauseFx/deliver/blob/master/Deliverfile.md
 
-# Use apple id set by produce
-apple_id ENV['PRODUCE_APPLE_ID']
+default_language "en-US"
+
+# Since this file is eval'd, we need to add this file's directory to $LOAD_PATH
+$:.unshift File.dirname(__FILE__)
+require 'lib/utils.rb'
+
+ENV['DELIVER_WHAT_TO_TEST'] = git_commit_log
+
+automatic_release false
 
 copyright "#{Time.now.year} Wikimedia Foundation"
-
-# This folder has to include one folder for each language
-# More information about automatic screenshot upload:
-# https://github.com/KrauseFx/deliver#upload-screenshots-to-itunes-connect
-
-screenshots_path "./screenshots/"
-
-# version '1.2' # you can pass this if you want to verify the version number 
with the ipa file
-config_json_folder './deliver'
 
diff --git a/fastlane/Fastfile b/fastlane/Fastfile
index 9aab23a..3b912f8 100644
--- a/fastlane/Fastfile
+++ b/fastlane/Fastfile
@@ -1,116 +1,110 @@
 # Customise this file, documentation can be found here:
-# https://github.com/krausefx/fastlane#customise-the-fastfile
-# vim: ft=ruby
+# https://github.com/KrauseFx/fastlane/tree/master/docs
+# vi: ft=ruby
 
-# Since this file is eval'd, we need to add this file's directory to $LOAD_PATH
+# By default, fastlane will send which actions are used
+# No personal data is shared, more information on 
https://github.com/fastlane/enhancer
+# Uncomment the following line to opt out
+# opt_out_usage
+
 $:.unshift File.dirname(__FILE__)
-
 require 'lib/utils.rb'
 
-ENV['WMF_VERSION_NUMBER'] ||= get_version_short_string 
File.expand_path(File.join(ENV['PWD'], 'Wikipedia/Wikipedia-Info.plist'))
+default_platform :ios
 
-before_all do
-  p ENV
+platform :ios do
+  before_all do
+     ensure_git_status_clean
+  end
+
+  desc "Runs linting (and eventually static analysis"
+  lane :analyze do
+    return if test_disabled?
+    make 'lint'
+  end
+
+  desc "Runs all the unit tests."
+  lane :test do
+    return if test_disabled?
+    # TODO: lint & test JS code
+    xctest({
+      scheme: 'Wikipedia',
+      destination: "platform=iOS Simulator,name=iPhone 6,OS=8.3",
+      reports: [
+        {
+          report: "html",
+          output: "build/reports/unit-tests.html"
+        },
+        {
+          report: "junit",
+          output: "build/reports/unit-tests.xml"
+        }
+      ],
+      clean: nil
+    })
+  end
+
+  desc "Bump the version, and submit a new **Wikipedia Alpha** Build to Apple 
TestFlight"
+  lane :alpha do
+    # snapshot
+    sigh
+
+    plist_version = get_version_short_string 
File.expand_path(File.join(ENV['PWD'], 'Wikipedia/Wikipedia-Info.plist'))
+
+    increment_version_number(
+      version_number: ENV['WMF_VERSION_NUMBER'] || plist_version
+    )
+    increment_build_number(
+      build_number: ENV['BUILD_NUMBER'].to_i
+    )
+    ipa(
+      configuration: "Alpha",
+      scheme: "Wikipedia Alpha",
+    )
+    hockey({
+      notes: '',
+      notify: '0', #Means do not notify
+      status: '1', #Means do not make available for download
+    })
+    deliver skip_deploy: true, beta: true
+  end
+
+  desc "Submit a new **Wikipedia Beta** build to Apple TestFlight"
+  lane :beta do
+    # snapshot
+    sigh
+    ipa(
+      configuration: "Beta",
+      scheme: "Wikipedia Beta",
+    )
+    hockey({
+      notes: '',
+      notify: '0', #Means do not notify
+      status: '1', #Means do not make available for download
+    })
+    deliver skip_deploy: true, beta: true
+  end
+
+  desc "Deploy a new version to the App Store"
+  lane :store do
+    # snapshot
+    sigh
+    ipa(
+      configuration: "Wikipedia",
+      scheme: "Wikipedia",
+    )
+    hockey({
+      notes: '',
+      notify: '0', #Means do not notify
+      status: '1', #Means do not make available for download
+    })
+    deliver skip_deploy: true, force: true
+  end
+
+  after_all do |lane|
+  end
+
+  error do |lane, exception|
+  end
 end
 
-lane :test do
-  make 'lint'
-  run_unit_tests
-end
-
-lane :alpha do
-  ensure_git_status_clean
-
-  run_unit_tests
-
-  # Download the Certificate for signing
-  cert
-
-  # Create and/or download the right provisioning profile
-  sigh({
-    force: true,
-    provisioning_name: 'TF Alpha',
-    app_identifier: 'org.wikimedia.wikipedia.tfalpha',
-  })
-
-  # Create the app in iTunes Connect if needed
-  produce({
-    produce_username: ENV['WMF_APPLE_USER_NAME'],
-    produce_app_identifier: 'org.wikimedia.wikipedia.tfalpha',
-    produce_app_identifier_suffix: '', #work around for: 
https://github.com/KrauseFx/produce/issues/27
-    produce_app_name: 'Wikipedia Alpha',
-    produce_language: 'English',
-    produce_version: ENV['WMF_VERSION_NUMBER'],
-    produce_sku: '01985',
-  })
-
-  deploy_testflight_build 'Wikipedia Alpha', 'Alpha'
-end
-
-lane :beta do
-  ensure_git_status_clean
-
-  run_unit_tests
-
-  # Download the Certificate for signing
-  cert
-
-  # Create and/or download the right provisioning profile
-  sigh({
-    force: true,
-    provisioning_name: 'TF Beta',
-    app_identifier: 'org.wikimedia.wikipedia.tfbeta',
-  })
-
-  # Create the app in iTunes Connect if needed
-  produce({
-    produce_username: ENV['WMF_APPLE_USER_NAME'],
-    produce_app_identifier: 'org.wikimedia.wikipedia.tfbeta',
-    produce_app_identifier_suffix: '', #work around for: 
https://github.com/KrauseFx/produce/issues/27
-    produce_app_name: 'Wikipedia Beta',
-    produce_language: 'English',
-    produce_version: ENV['WMF_VERSION_NUMBER'],
-    produce_sku: '01984',
-  })
-
-  deploy_testflight_build 'Wikipedia Beta', 'Beta'
-end
-
-# Untested!
-lane :appstore do
-  ensure_git_status_clean
-
-  run_unit_tests
-
-  # Download the Certificate for signing
-  cert
-
-  # Create and/or download the right provisioning profile
-  sigh({
-    provisioning_name: 'org.wikimedia.wikipedia AppStore',
-    app_identifier: 'org.wikimedia.wikipedia',
-  })
-
-  # Create the app in iTunes Connect if needed
-  produce({
-    produce_username: ENV['WMF_APPLE_USER_NAME'],
-    produce_app_identifier: 'org.wikimedia.wikipedia',
-    produce_app_identifier_suffix: '', #work around for: 
https://github.com/KrauseFx/produce/issues/27
-    produce_app_name: 'Wikipedia Mobile',
-    produce_language: 'English',
-    produce_version: ENV['WMF_VERSION_NUMBER'],
-    produce_sku: '01982',
-  })
-
-  # Set variables for building and distributing
-  ENV['IPA_BUILD_SCHEME'] = 'Wikipedia'
-  ENV['IPA_BUILD_CONFIG'] = 'Release'
-  ENV['APP_APPLE_ID'] = '324715238'
-
-  deploy_appstore_build
-end
-# after_all do |lane|
-# end
-
-# error do |lane, exception|
-# end
diff --git a/fastlane/Snapfile b/fastlane/Snapfile
deleted file mode 100644
index ffea45b..0000000
--- a/fastlane/Snapfile
+++ /dev/null
@@ -1,53 +0,0 @@
-# Uncomment the lines below you want to change by removing the # in the 
beginning
-
-# A list of devices you want to take the screenshots from
-devices([
-  "iPhone 6",
-  "iPhone 6 Plus",
-  "iPhone 5",
-  "iPhone 4s",
-  "iPad Air"
-])
-
-languages([
-  'en-US',
-  'de-DE',
-  'it-IT'
-])
-
-# Where should the resulting screenshots be stored?
-screenshots_path "./screenshots"
-
-# clear_previous_screenshots # remove the '#'' to clear all previously 
generated screenshots before creating new ones
-
-# JavaScript UIAutomation file
-# js_file './snapshot.js'
-
-# The name of the project's scheme
-# scheme 'SchemeName'
-
-# Where is your project (or workspace)? Provide the full path here
-# project_path './YourProject.xcworkspace'
-
-# By default, the latest version should be used automatically. If you want to 
change it, do it here
-# ios_version '8.1'
-
-# Custom Callbacks
-
-# setup_for_device_change do |device|
-#   puts "Preparing device: #{device}"
-# end
-
-# setup_for_language_change do |lang, device|
-#   puts "Running #{lang} on #{device}"
-#   system("./popuplateDatabase.sh")
-# end
-
-# teardown_language do |lang, device|
-#   puts "Finished with #{lang} on #{device}"
-# end
-
-# teardown_device do |device|
-#   puts "Cleaning device #{device}"
-#   system("./cleanup.sh")
-# end
diff --git a/fastlane/SnapshotHelper.js b/fastlane/SnapshotHelper.js
deleted file mode 100644
index a54a504..0000000
--- a/fastlane/SnapshotHelper.js
+++ /dev/null
@@ -1,58 +0,0 @@
-function wait_for_loading_indicator_to_be_finished()
-{
-  try {
-    re = 
UIATarget.localTarget().frontMostApp().statusBar().elements()[2].rect();
-    re2 = 
UIATarget.localTarget().frontMostApp().statusBar().elements()[3].rect();
-    while ((re['size']['width'] == 10 && re['size']['height'] == 20) ||
-           (re2['size']['width'] == 10 && re2['size']['height'] == 20))
-     {
-      UIALogger.logMessage("Loading indicator is visible... waiting");
-      UIATarget.localTarget().delay(1);
-      re = 
UIATarget.localTarget().frontMostApp().statusBar().elements()[2].rect();
-      re2 = 
UIATarget.localTarget().frontMostApp().statusBar().elements()[3].rect();
-    }
-  } catch (e) {}
-}
-
-function captureLocalizedScreenshot(name) {
-  wait_for_loading_indicator_to_be_finished();
-
-  var target = UIATarget.localTarget();
-  var model = target.model();
-  var rect = target.rect();
-  var deviceOrientation = target.deviceOrientation();
-
-  var theSize = (rect.size.width > rect.size.height) ? 
rect.size.width.toFixed() : rect.size.height.toFixed();
-
-  if (model.match(/iPhone/))
-  {
-    if (theSize > 667) {
-      model = "iPhone6Plus";
-    } else if (theSize == 667) {
-      model = "iPhone6";
-    } else if (theSize == 568){
-      model = "iPhone5";
-    } else {
-    model = "iPhone4";
-    }
-  }
-  else
-  {
-    model = "iOS-iPad";
-  }
-
-  var orientation = "portrait";
-  if (deviceOrientation == UIA_DEVICE_ORIENTATION_LANDSCAPELEFT) {
-    orientation = "landscapeleft";
-  } else if (deviceOrientation == UIA_DEVICE_ORIENTATION_LANDSCAPERIGHT) {
-    orientation = "landscaperight";
-  } else if (deviceOrientation == UIA_DEVICE_ORIENTATION_PORTRAIT_UPSIDEDOWN) {
-    orientation = "portrait_upsidedown";
-  }
-
-  var result = 
target.host().performTaskWithPathArgumentsTimeout("/usr/bin/printenv" , 
["SNAPSHOT_LANGUAGE"], 5);
-  var language = result.stdout.substring(0, result.stdout.length - 1);
-
-  var parts = [language, model, name, orientation];
-  target.captureScreenWithName(parts.join("-"));
-}
diff --git a/fastlane/deliver/metadata.json b/fastlane/deliver/metadata.json
deleted file mode 100644
index 7181796..0000000
--- a/fastlane/deliver/metadata.json
+++ /dev/null
@@ -1,15 +0,0 @@
-{
-  "en-US": {
-    "title": "Wikipedia Mobile",
-    "description": "Official Wikipedia App for iOS. Wikipedia is the free 
encyclopedia containing more than 32 million articles in 280 languages, and is 
the most comprehensive and widely used reference work humans have ever 
compiled. The app has been rewritten from scratch and is better than ever 
before.\n\nFeatures:\n\n* Speed, the app is faster than ever.\n\n* Editing both 
logged in or not.\n\n* Recent pages so you never got lost in the depths of 
Wikipedia.\n\n* Save pages for offline reading.\n\n* Share articles with 
others.\n\n* Read articles in a different language.\n\n* Wikipedia Zero, 
supporting zero-rated access with participating carriers.\n\nThe code is 100% 
open source and community built. If you are a developer and good at 
Objective-C, then check us 
out:\nhttp://git.wikimedia.org/summary/?r=apps/ios/wikipedia.git";,
-    "software_url": "",
-    "support_url": "https://www.mediawiki.org/wiki/Wikimedia_Apps/Support";,
-    "privacy_url": "http://wikimediafoundation.org/wiki/Privacy_policy";,
-    "keywords": [
-      "Wikipedia",
-      "Reference",
-      "wiki",
-      "encyclopedia"
-    ]
-  }
-}
\ No newline at end of file
diff --git a/fastlane/lib/utils.rb b/fastlane/lib/utils.rb
index fae99df..8ce89aa 100644
--- a/fastlane/lib/utils.rb
+++ b/fastlane/lib/utils.rb
@@ -69,70 +69,3 @@
   plist_hash = info_plist_to_hash path
   plist_hash['CFBundleShortVersionString']
 end
-
-def deploy_testflight_build(scheme, config)
-  return if deploy_disabled?
-
-  increment_version_number(
-    version_number: ENV['WMF_VERSION_NUMBER']
-  )
-
-  # use Jenkins build number
-  increment_build_number(
-    build_number: ENV['BUILD_NUMBER'].to_i
-  )
-
-  # Create and sign the IPA (and DSYM)
-  ipa({
-    scheme: scheme,
-    configuration: config, #Prevents fastlane from passing --configuration 
"Release" - bug?
-    clean: true,
-    archive: nil,
-    # verbose: nil, # this means 'Be Verbose'.
-  })
-
-  # Upload the DSYM to Hockey
-  hockey({
-    notes: '',
-    notify: '0', #Means do not notify
-    status: '1', #Means do not make available for download
-  })
-
-  #Set "What To Test" in iTunes Connect for Testflight builds, in the future, 
reference tickets instead of git commits
-  ENV['DELIVER_WHAT_TO_TEST'] = git_commit_log
-  #Set "App Description" in iTunes Connect for Testflight builds, in the 
future set a better description
-  # ENV['DELIVER_BETA_DESCRIPTION'] = git_commit_log
-
-  # Upload the IPA and DSYM to iTunes Connect
-  deliver(
-    force: true, # Set to true to skip PDF verification
-    beta: true, # Upload a new version to TestFlight
-    skip_deploy: true, # Set true to not submit app for review (works with 
both App Store and beta builds)
-  )
-end
-
-def deploy_appstore_build
-  return if deploy_disabled?
-  # Create and sign the IPA (and DSYM)
-  ipa({
-    scheme: ENV['IPA_BUILD_SCHEME'],
-    configuration: ENV['IPA_BUILD_CONFIG'], #Prevents fastlane from passing 
--configuration "Release" - bug?
-    clean: true,
-    archive: nil,
-    # verbose: nil, # this means 'Be Verbose'.
-  })
-
-  # Upload the DSYM to Hockey
-  hockey({
-    notes: '',
-    notify: '0', #Means do not notify
-    status: '1', #Means do not make available for download
-  })
-
-  # Upload the IPA and DSYM to iTunes Connect
-  deliver(
-    force: true, # Set to true to skip PDF verification
-    skip_deploy: true, # Set true to not submit app for review (works with 
both App Store and beta builds)
-  )
-end
-
diff --git a/fastlane/metadata/en-US/description.txt 
b/fastlane/metadata/en-US/description.txt
new file mode 100644
index 0000000..ea5ac4b
--- /dev/null
+++ b/fastlane/metadata/en-US/description.txt
@@ -0,0 +1,42 @@
+Official Wikipedia App for iOS. Wikipedia is the free encyclopedia containing 
more than 32 million articles in 280 languages, and is the most comprehensive 
and widely used reference work humans have ever compiled.
+
+
+App features:
+
+* Better search results with short descriptions of matching articles
+
+* Search for and read Wikipedia articles written in any language
+
+* Quickly share facts as image cards or text
+
+* Saved pages for when you don't have a data connection
+
+* Prominent image and description at the top of many articles
+
+* High resolution image galleries
+
+* Related article suggestions at the bottom of each article
+
+* Nearby articles for exploring your current location
+
+* Swipe left for quick section navigation table of contents
+
+* Wikipedia Zero: data charges waived for participating mobile operators
+
+Apps FAQ:
+https://www.mediawiki.org/wiki/Wikimedia_Apps/FAQ
+
+Contribute to our translations:
+https://translatewiki.net/wiki/Translating:WikimediaMobile
+
+Open source repository:
+https://github.com/wikimedia/apps-ios-wikipedia
+
+Privacy policy:
+https://m.wikimediafoundation.org/wiki/Privacy_policy
+
+Terms of Use:
+https://m.wikimediafoundation.org/wiki/Terms_of_Use
+
+To send feedback in the app tap:
+W > More > About the Wikipedia app > Send app feedback
\ No newline at end of file
diff --git a/fastlane/metadata/en-US/keywords.txt 
b/fastlane/metadata/en-US/keywords.txt
new file mode 100644
index 0000000..33a7f81
--- /dev/null
+++ b/fastlane/metadata/en-US/keywords.txt
@@ -0,0 +1,4 @@
+Wikipedia
+Reference
+wiki
+encyclopedia
\ No newline at end of file
diff --git a/fastlane/metadata/en-US/privacy_url.txt 
b/fastlane/metadata/en-US/privacy_url.txt
new file mode 100644
index 0000000..fb33421
--- /dev/null
+++ b/fastlane/metadata/en-US/privacy_url.txt
@@ -0,0 +1 @@
+https://m.wikimediafoundation.org/wiki/Privacy_policy
\ No newline at end of file
diff --git a/fastlane/metadata/en-US/software_url.txt 
b/fastlane/metadata/en-US/software_url.txt
new file mode 100644
index 0000000..2c9afd8
--- /dev/null
+++ b/fastlane/metadata/en-US/software_url.txt
@@ -0,0 +1 @@
+https://blog.wikimedia.org/2015/04/15/new-release-wikipedia-app-ios/
\ No newline at end of file
diff --git a/fastlane/metadata/en-US/support_url.txt 
b/fastlane/metadata/en-US/support_url.txt
new file mode 100644
index 0000000..ee7d9eb
--- /dev/null
+++ b/fastlane/metadata/en-US/support_url.txt
@@ -0,0 +1 @@
+https://m.mediawiki.org/wiki/Wikimedia_Apps/Team
\ No newline at end of file
diff --git a/fastlane/metadata/en-US/title.txt 
b/fastlane/metadata/en-US/title.txt
new file mode 100644
index 0000000..b4ed161
--- /dev/null
+++ b/fastlane/metadata/en-US/title.txt
@@ -0,0 +1 @@
+Wikipedia Mobile
\ No newline at end of file
diff --git a/fastlane/metadata/en-US/version_whats_new.txt 
b/fastlane/metadata/en-US/version_whats_new.txt
new file mode 100644
index 0000000..fa02226
--- /dev/null
+++ b/fastlane/metadata/en-US/version_whats_new.txt
@@ -0,0 +1,37 @@
+Hi all!
+
+First, thanks to everyone for all of your feedback and comments. We have been 
working hard to fix bugs and your feedback has been extremely helpful to us. 
Please continue to leave reviews - we are reading them!
+
+Second, we started an FAQ for our app here: 
https://www.mediawiki.org/wiki/Wikimedia_Apps/FAQ. Check it out if you have 
questions.
+
+Third, as you may of noticed, we are also releasing more frequent updates. We 
want to make sure we get fixes out to everyone as fast as possible. Reading 
your reviews doesn’t do us much good if we don’t ship our fixes!
+
+Whew! With that out of the way, here is what’s in the latest release. (Hint: 
Bug fixes!)
+
+* Faster page rendering!
+
+* Re-added a ”delete all" button saved pages
+
+* New buttons to see "similar pages" and "page issues" in an article
+
+* Fix to properly display Latin titles. I’m looking at you, Lichtheimia 
corymbifera!
+
+* Added more informative descriptions to the saved pages list
+
+* New translations - Thanks to everyone who contributed, we are truly 
grateful! This app wouldn’t be possible without your contributions. (If you 
would like to help translate our app, please check out this link to find out 
more: https://translatewiki.net/wiki/Translating:WikimediaMobile)
+
+* Many fixes to make info boxes and tables work more reliably
+
+* Various fixes to improve overall article viewing and loading
+
+* Fix for images not displaying properly in lists
+
+* Fix for a crash when viewing an image gallery
+
+* Several fixes for crashes that occur during data migration
+
+* Numerous other crash fixes
+
+Once again, thanks to all of you for using the Wikipedia iOS app and helping 
us make it better.
+
+- The Wikimedia Reading Team
\ No newline at end of file
diff --git a/fastlane/snapshot-iPad.js b/fastlane/snapshot-iPad.js
deleted file mode 100644
index 8a63a56..0000000
--- a/fastlane/snapshot-iPad.js
+++ /dev/null
@@ -1,9 +0,0 @@
-#import "SnapshotHelper.js"
-
-var target = UIATarget.localTarget();
-var app = target.frontMostApp();
-var window = app.mainWindow();
-
-
-target.delay(3);
-captureLocalizedScreenshot("0-LandingScreen");
diff --git a/fastlane/snapshot.js b/fastlane/snapshot.js
deleted file mode 100644
index 8a63a56..0000000
--- a/fastlane/snapshot.js
+++ /dev/null
@@ -1,9 +0,0 @@
-#import "SnapshotHelper.js"
-
-var target = UIATarget.localTarget();
-var app = target.frontMostApp();
-var window = app.mainWindow();
-
-
-target.delay(3);
-captureLocalizedScreenshot("0-LandingScreen");

-- 
To view, visit https://gerrit.wikimedia.org/r/210206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab9e2f32f1a41f4b7a6b75db47948aa2f3047a9e
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle <bgers...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to