Tamslo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210288
Change subject: Adapted description of special page
......................................................................
Adapted description of special page
Change-Id: I6a439bee0e3b80b5f57ae37d0533bf594b9c22ab
---
M i18n/en.json
M i18n/qqq.json
M modules/ext.WikibaseExternalValidation.SpecialCrossCheckPage.css
M specials/SpecialCrossCheck.php
4 files changed, 46 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityExternalValidation
refs/changes/88/210288/1
diff --git a/i18n/en.json b/i18n/en.json
index 0305be8..016a47e 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -4,9 +4,13 @@
},
"wbqev-crosscheck": "Cross-Check with external databases",
- "wbqev-crosscheck-instructions": "Enter an entity ID and let it cross-check
against GND.",
- "wbqev-crosscheck-instructions-example": "Try for example Q159099 (Nina
Hagen) and look at the results.",
- "wbqev-crosscheck-form-entityid-placeholder": "Qxx/Pxx",
+ "wbqev-crosscheck-infotext-01": "This special page performs cross-checks
between items in Wikidata and external databases.",
+ "wbqev-crosscheck-infotext-02.1": "You can check the databases we use on the
special page ",
+ "wbqev-crosscheck-infotext-02.2": " List of external databases",
+ "wbqev-crosscheck-infotext-02.3": ".",
+ "wbqev-crosscheck-infotext-03": "To revise an item enter its id. The values
of each validatable property are compared to the value in the database and the
result is presented here.",
+ "wbqev-crosscheck-infotext-04": "Additionally we check whether references
are missing or can be added in form of the database that states the same fact.",
+ "wbqev-crosscheck-form-entityid-placeholder": "Qxx",
"wbqev-crosscheck-form-submit-label": "Check",
"wbqev-crosscheck-invalid-entity-id": "Invalid entity ID!",
"wbqev-crosscheck-not-existent-entity": "Entity does not exist!",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 8f0f7c3..cebf766 100755
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -8,8 +8,12 @@
]
},
"wbqev-crosscheck": "{{doc-special|CrossCheck}}",
- "wbqev-crosscheck-instructions": "Instructions for starting a cross-check
against external databases.",
- "wbqev-crosscheck-instructions-example": "Example, what to enter to get good
results for external validation. Q159099 is suitable.",
+ "wbqev-crosscheck-infotext-01": "Explanation text for special page part one",
+ "wbqev-crosscheck-infotext-02.1": "Explanation text for special page part
two.1",
+ "wbqev-crosscheck-infotext-02.2": "Explanation text for special page part
two.2",
+ "wbqev-crosscheck-infotext-02.3": "Explanation text for special page part
two.3",
+ "wbqev-crosscheck-infotext-03": "Explanation text for special page part
tree",
+ "wbqev-crosscheck-infotext-04": "Explanation text for special page part
four",
"wbqev-crosscheck-form-entityid-placeholder": "Entity id placeholder for the
input field.",
"wbqev-crosscheck-form-submit-label": "Label of the button, that starts the
check.\n{{Identical|Check}}",
"wbqev-crosscheck-invalid-entity-id": "Error message that appears when the
entered string is not a valid entity id.",
diff --git a/modules/ext.WikibaseExternalValidation.SpecialCrossCheckPage.css
b/modules/ext.WikibaseExternalValidation.SpecialCrossCheckPage.css
index b910a6a..9a3033d 100755
--- a/modules/ext.WikibaseExternalValidation.SpecialCrossCheckPage.css
+++ b/modules/ext.WikibaseExternalValidation.SpecialCrossCheckPage.css
@@ -41,4 +41,8 @@
.wbqev-status-unknown {
color: #404040;
+}
+
+.wbqev-infobox {
+ width: 50%;
}
\ No newline at end of file
diff --git a/specials/SpecialCrossCheck.php b/specials/SpecialCrossCheck.php
index 7156f5b..ab00077 100755
--- a/specials/SpecialCrossCheck.php
+++ b/specials/SpecialCrossCheck.php
@@ -145,9 +145,7 @@
$this->setHeaders();
$out->addHTML(
- $this->msg( 'wbqev-crosscheck-instructions' )->text()
- . Html::element( 'br' )
- . $this->msg( 'wbqev-crosscheck-instructions-example' )->text()
+ $this->buildInfobox()
. $this->buildEntityIdForm()
);
@@ -230,6 +228,34 @@
}
/**
+ * Builds infobox with explanation for this special page
+ *
+ * @return string
+ */
+ private function buildInfobox() {
+ $infobox =
+ Html::openElement(
+ 'div',
+ array( 'class' => 'wbqev-infobox' )
+ )
+ . $this->msg( 'wbqev-crosscheck-infotext-01')->text()
+ . Html::element( 'br' )
+ . $this->msg( 'wbqev-crosscheck-infotext-02.1' )->text()
+ . Linker::linkKnown(
+ self::getTitleFor( 'ExternalDbs' ),
+ $this->msg( 'wbqev-crosscheck-infotext-02.2' )->text() )
+ . $this->msg( 'wbqev-crosscheck-infotext-02.3' )->text()
+ . Html::element( 'br' )
+ . Html::element( 'br' )
+ . $this->msg( 'wbqev-crosscheck-infotext-03' )->text()
+ . Html::element( 'br' )
+ . Html::element( 'br' )
+ . $this->msg( 'wbqev-crosscheck-infotext-04' )->text()
+ . Html::closeElement( 'div' );
+ return $infobox;
+ }
+
+ /**
* Builds notice with given message. Optionally notice can be handles as
error by settings $error to true
*
* @param string $message
--
To view, visit https://gerrit.wikimedia.org/r/210288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a439bee0e3b80b5f57ae37d0533bf594b9c22ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: v1
Gerrit-Owner: Tamslo <tamaraslosa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
