[MediaWiki-commits] [Gerrit] merge pull request #13 - change (apps...wikipedia)

[Bgerstle (Code Review)]

Bgerstle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/210532

Change subject: merge pull request #13
......................................................................

merge pull request #13

- Removed {} from action calls
- Some clean ups of the Fastfile
- Also added `fastlane_version` to make sure a certain fastlane version is 
being used. It's a good thing to have, even if you use `bundle exec`

Change-Id: If89b9d852fe341cabd055335f194dc0598a8f6b5
---
M fastlane/Fastfile
1 file changed, 19 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/32/210532/1

diff --git a/fastlane/Fastfile b/fastlane/Fastfile
index 3b912f8..8bdd8cc 100644
--- a/fastlane/Fastfile
+++ b/fastlane/Fastfile
@@ -2,13 +2,10 @@
 # https://github.com/KrauseFx/fastlane/tree/master/docs
 # vi: ft=ruby
 
-# By default, fastlane will send which actions are used
-# No personal data is shared, more information on 
https://github.com/fastlane/enhancer
-# Uncomment the following line to opt out
-# opt_out_usage
-
 $:.unshift File.dirname(__FILE__)
 require 'lib/utils.rb'
+
+fastlane_version "1.0.0"
 
 default_platform :ios
 
@@ -17,7 +14,7 @@
      ensure_git_status_clean
   end
 
-  desc "Runs linting (and eventually static analysis"
+  desc "Runs linting (and eventually static analysis)"
   lane :analyze do
     return if test_disabled?
     make 'lint'
@@ -27,7 +24,7 @@
   lane :test do
     return if test_disabled?
     # TODO: lint & test JS code
-    xctest({
+    xctest(
       scheme: 'Wikipedia',
       destination: "platform=iOS Simulator,name=iPhone 6,OS=8.3",
       reports: [
@@ -41,7 +38,7 @@
         }
       ],
       clean: nil
-    })
+    )
   end
 
   desc "Bump the version, and submit a new **Wikipedia Alpha** Build to Apple 
TestFlight"
@@ -61,11 +58,11 @@
       configuration: "Alpha",
       scheme: "Wikipedia Alpha",
     )
-    hockey({
+    hockey(
       notes: '',
-      notify: '0', #Means do not notify
-      status: '1', #Means do not make available for download
-    })
+      notify: '0', # Means do not notify
+      status: '1', # Means do not make available for download
+    )
     deliver skip_deploy: true, beta: true
   end
 
@@ -77,11 +74,11 @@
       configuration: "Beta",
       scheme: "Wikipedia Beta",
     )
-    hockey({
+    hockey(
       notes: '',
-      notify: '0', #Means do not notify
-      status: '1', #Means do not make available for download
-    })
+      notify: '0', # Means do not notify
+      status: '1', # Means do not make available for download
+    )
     deliver skip_deploy: true, beta: true
   end
 
@@ -93,18 +90,19 @@
       configuration: "Wikipedia",
       scheme: "Wikipedia",
     )
-    hockey({
+    hockey(
       notes: '',
-      notify: '0', #Means do not notify
-      status: '1', #Means do not make available for download
-    })
+      notify: '0', # Means do not notify
+      status: '1', # Means do not make available for download
+    )
     deliver skip_deploy: true, force: true
   end
 
   after_all do |lane|
+  
   end
 
   error do |lane, exception|
+  
   end
 end
-

-- 
To view, visit https://gerrit.wikimedia.org/r/210532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If89b9d852fe341cabd055335f194dc0598a8f6b5
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle <bgers...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits