Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210613
Change subject: convert svgs-to-pngs using convert
......................................................................
convert svgs-to-pngs using convert
Change-Id: I1393b8aee0eb5b4a77bf000cd953271edbba4f56
---
M scripts/make-icons-from-svg.sh
1 file changed, 10 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/13/210613/2
diff --git a/scripts/make-icons-from-svg.sh b/scripts/make-icons-from-svg.sh
index eb3c672..0d6167d 100755
--- a/scripts/make-icons-from-svg.sh
+++ b/scripts/make-icons-from-svg.sh
@@ -1,12 +1,13 @@
-# This script takes icon-prod.svg and creates pngs used for AppIcon assets.
-#
-# Note: it's much easier to just run this in Ubuntu:
-# - copy this script and icon-prod.svg to a folder
-# - with terminal change to that folder
-# - then run './make-icons-from-svg.sh'
-# - the various png resolutions specified below will be output to the folder
+#! env ruby
-ruby -e '[29,40,50,57,58,80,100,72,76,87,114,120,144,152,180].each { |x|
`inkscape --export-png ./icon_#{x}.png -w #{x} icon-prod.svg` }'
+# This script uses convert (from imagemagick) to convert icon-prod.svg into
pngs used for AppIcon assets.
+# Be sure to run it from the project's root directory
-ruby -e '[29,58,80,120].each { |x| `inkscape --export-png ./icon_#{x}_copy.png
-w #{x} icon-prod.svg` }'
+def convert(x)
+ puts "Converting svgs/icon-prod.svg to #{x}x#{x} png..."
+ `convert -density 500 -resize #{x}x#{x} svgs/icon-prod.svg ./icon_#{x}.png`
+end
+[29,40,50,57,58,80,100,72,76,87,114,120,144,152,180].each { |x| convert x }
+
+[29,58,80,120].each { |x| convert x }
--
To view, visit https://gerrit.wikimedia.org/r/210613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1393b8aee0eb5b4a77bf000cd953271edbba4f56
Gerrit-PatchSet: 2
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle <bgers...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
