jenkins-bot has submitted this change and it was merged.
Change subject: Handle image map links in-app
......................................................................
Handle image map links in-app
Bug: T87066
Change-Id: I79be02fa6e0bced25e47b0ea6100c9460be8ea7e
---
M wikipedia/assets/bundle.js
M wikipedia/assets/preview.js
M www/js/actions.js
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/assets/bundle.js b/wikipedia/assets/bundle.js
index 35629c3..902744c 100644
--- a/wikipedia/assets/bundle.js
+++ b/wikipedia/assets/bundle.js
@@ -45,7 +45,7 @@
// If an element was clicked, check if it or any of its parents are <a>
// This handles cases like <a>foo</a>, <a><strong>foo</strong></a>, etc.
while (curNode) {
- if (curNode.tagName === "A") {
+ if (curNode.tagName === "A" || curNode.tagName === "AREA") {
sourceNode = curNode;
break;
}
diff --git a/wikipedia/assets/preview.js b/wikipedia/assets/preview.js
index c466d77..0796873 100644
--- a/wikipedia/assets/preview.js
+++ b/wikipedia/assets/preview.js
@@ -45,7 +45,7 @@
// If an element was clicked, check if it or any of its parents are <a>
// This handles cases like <a>foo</a>, <a><strong>foo</strong></a>, etc.
while (curNode) {
- if (curNode.tagName === "A") {
+ if (curNode.tagName === "A" || curNode.tagName === "AREA") {
sourceNode = curNode;
break;
}
diff --git a/www/js/actions.js b/www/js/actions.js
index ea79aaf..705b724 100644
--- a/www/js/actions.js
+++ b/www/js/actions.js
@@ -44,7 +44,7 @@
// If an element was clicked, check if it or any of its parents are <a>
// This handles cases like <a>foo</a>, <a><strong>foo</strong></a>, etc.
while (curNode) {
- if (curNode.tagName === "A") {
+ if (curNode.tagName === "A" || curNode.tagName === "AREA") {
sourceNode = curNode;
break;
}
--
To view, visit https://gerrit.wikimedia.org/r/207284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79be02fa6e0bced25e47b0ea6100c9460be8ea7e
Gerrit-PatchSet: 5
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Bgerstle <bgers...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
