jenkins-bot has submitted this change and it was merged.
Change subject: [BrowserTest] Fix the special character button screenshot
......................................................................
[BrowserTest] Fix the special character button screenshot
The element moved out of the Insert menu to the toolbar.
Change-Id: I7c563af858a37f360bd2e4b4ba2e8a7098bc94e6
---
M modules/ve-mw/tests/browser/features/language_screenshot.feature
M
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
3 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/tests/browser/features/language_screenshot.feature
b/modules/ve-mw/tests/browser/features/language_screenshot.feature
index 12820f1..4469dbb 100644
--- a/modules/ve-mw/tests/browser/features/language_screenshot.feature
+++ b/modules/ve-mw/tests/browser/features/language_screenshot.feature
@@ -28,7 +28,7 @@
@language_screenshot
Scenario: VisualEditor_Toolbar_SpecialCharacters
Given I am editing the language screenshots page
- When I click on the Special character option in Insert menu
+ When I click on the Special character option in the toolbar
Then I should see Special character Insertion window
@language_screenshot
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index f71f71f..2f558a2 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -54,9 +54,7 @@
on(VisualEditorPage).insert_indicator_down_element.when_present.click
end
-When(/^I click on the Special character option in Insert menu$/) do
- step 'I click on the Insert menu'
- step 'I click on More in the pull-down menu'
+When(/^I click on the Special character option in the toolbar$/) do
on(VisualEditorPage).special_character_element.when_present.click
end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index a58637c..19b1ae3 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -147,7 +147,7 @@
a(:second_reference, text: '[1]', index: 2)
span(:second_save_page, css: '.oo-ui-processDialog-actions-primary >
div:nth-child(1) > a:nth-child(1) > span:nth-child(2)')
div(:settings_apply_button, css: '.oo-ui-window-frame
.oo-ui-processDialog-actions-primary')
- span(:special_character, class: 'oo-ui-iconElement-icon
oo-ui-icon-special-character')
+ span(:special_character, class: 'oo-ui-iconElement-icon
oo-ui-icon-specialCharacter')
a(:subheading1, text: /Sub-heading 1/)
a(:subheading2, text: /Sub-heading 2/)
a(:subheading3, text: /Sub-heading 3/)
--
To view, visit https://gerrit.wikimedia.org/r/211104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c563af858a37f360bd2e4b4ba2e8a7098bc94e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
