Subramanya Sastry has uploaded a new change for review. https://gerrit.wikimedia.org/r/211146
Change subject: Don't use selser if oldid is missing ...................................................................... Don't use selser if oldid is missing So far, we were checking for absence of page-src while disabling selser. However, that is insufficient since rt-testing provides page-src to minmize dirty diffs. As per https://www.mediawiki.org/wiki/Parsoid/API#v1_API_entry_points "Both it and the oldid parameter are needed for clean round-tripping of HTML retrieved earlier with" So much for wanting to hide internal details (of selser) from the API. This does leak selser-ability via the API, but right now, there doesn't seem to be a clean way to support all the varied use cases for html2wt that provide title, oldid, and page src. The only way to disable selser right now is to NOT provide oldid. In this patch, we'll rely on that. Change-Id: I30cc1ea61b915096a512466578cec565fd5f56c0 --- M lib/mediawiki.SelectiveSerializer.js 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid refs/changes/46/211146/1 diff --git a/lib/mediawiki.SelectiveSerializer.js b/lib/mediawiki.SelectiveSerializer.js index a949f7f..cd8cfcc 100644 --- a/lib/mediawiki.SelectiveSerializer.js +++ b/lib/mediawiki.SelectiveSerializer.js @@ -46,7 +46,8 @@ var out; var startTimers = new Map(); - if ((!this.env.page.dom && !this.env.page.domdiff) || this.env.page.src === null) { + var hasOldId = (this.env.page.id && this.env.page.id !== '0'); + if ((!this.env.page.dom && !this.env.page.domdiff) || this.env.page.src === null || !hasOldId) { if (this.timer) { startTimers.set('html2wt.full.serialize', Date.now()); } -- To view, visit https://gerrit.wikimedia.org/r/211146 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I30cc1ea61b915096a512466578cec565fd5f56c0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
