Robert Vogel has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211668
Change subject: PermissionManager: Bugfix for deleting unsaved templates
......................................................................
PermissionManager: Bugfix for deleting unsaved templates
* needs cherry-pick to at least REL1_23
Change-Id: I41877891a04b7fa4ff5dc1c2924cb6c77247828e
---
M PermissionManager/resources/BS.PermissionManager/TemplateEditor.js
1 file changed, 9 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/68/211668/1
diff --git a/PermissionManager/resources/BS.PermissionManager/TemplateEditor.js
b/PermissionManager/resources/BS.PermissionManager/TemplateEditor.js
index 99e9803..ab77c04 100644
--- a/PermissionManager/resources/BS.PermissionManager/TemplateEditor.js
+++ b/PermissionManager/resources/BS.PermissionManager/TemplateEditor.js
@@ -142,9 +142,9 @@
rootVisible: false,
margins: '0 0 5 0',
listeners: {
- 'select': function(rm, record) {
- var data = [];
- for (var i in
me._permissionStore.data.items) {
+ 'select': function ( rm, record ) {
+ var data = [ ];
+ for ( var i in
me._permissionStore.data.items ) {
var dataSet =
me._permissionStore.data.items[i].data;
dataSet.enabled =
Ext.Array.contains(record.get('ruleSet'), dataSet.name);
data.push(dataSet);
@@ -247,8 +247,12 @@
handler: function() {
var record =
Ext.getCmp('bs-template-editor-treepanel')
.getSelectionModel().getLastSelected(),
- id = record.get('id');
-
+ id = record.get( 'id' );
+ //id == 0 if the template hasn't been
saved yet
+ if ( id === 0 ) {
+ record.remove( );
+ return true;
+ }
Ext.Ajax.request({
url:
bs.util.getAjaxDispatcherUrl('PermissionManager::deleteTemplate'),
method: 'POST',
--
To view, visit https://gerrit.wikimedia.org/r/211668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41877891a04b7fa4ff5dc1c2924cb6c77247828e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: Robert Vogel <vo...@hallowelt.biz>
Gerrit-Reviewer: Tweichart <weich...@hallowelt.biz>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
